third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py - Issue 2188623002: Change logging statements to not use the "%" operator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py

Issue 2188623002: Change logging statements to not use the "%" operator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py

index 25fb31697c4c72b98c74a28a595db5a7caba8aea..e0f620564ee8264cf54a86d9890b2aefa48544b4 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py

@@ -141,7 +141,7 @@ class LayoutTestFinder(object):

except IOError as e:

if e.errno == errno.ENOENT:

_log.critical('')

- _log.critical('--test-list file "%s" not found' % file)

+ _log.critical('--test-list file "%s" not found', file)

raise

return tests

@@ -190,7 +190,7 @@ class LayoutTestFinder(object):

test_size = int(chunk_len)

assert test_size > 0

except AssertionError:

- _log.critical("invalid chunk '%s'" % chunk_value)

+ _log.critical("invalid chunk '%s'", chunk_value)

return (None, None)

# Get the number of tests

@@ -223,13 +223,13 @@ class LayoutTestFinder(object):

tests_to_run = test_names[slice_start:slice_end]

- _log.debug('chunk slice [%d:%d] of %d is %d tests' % (slice_start, slice_end, num_tests, (slice_end - slice_start)))

+ _log.debug('chunk slice [%d:%d] of %d is %d tests', slice_start, slice_end, num_tests, (slice_end - slice_start))

# If we reached the end and we don't have enough tests, we run some

# from the beginning.

if slice_end - slice_start < chunk_len:

extra = chunk_len - (slice_end - slice_start)

- _log.debug(' last chunk is partial, appending [0:%d]' % extra)

+ _log.debug(' last chunk is partial, appending [0:%d]', extra)

tests_to_run.extend(test_names[0:extra])

return (tests_to_run, set(test_names) - set(tests_to_run))