Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py

Issue 2188623002: Change logging statements to not use the "%" operator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py
index f569cedfc071eec7f27bb5c99f3204c223ca3eff..5b77580ff787dd91280a96e15f274a4de09e0a23 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py
@@ -285,10 +285,10 @@ class BaselineOptimizer(object):
if new_results_by_directory == results_by_directory:
if new_results_by_directory:
- _log.debug(" %s: (already optimal)" % basename)
+ _log.debug(" %s: (already optimal)", basename)
self.write_by_directory(results_by_directory, _log.debug, " ")
else:
- _log.debug(" %s: (no baselines found)" % basename)
+ _log.debug(" %s: (no baselines found)", basename)
# This is just used for unittests. Intentionally set it to the old data if we don't modify anything.
self.new_results_by_directory.append(results_by_directory)
return True
@@ -297,11 +297,11 @@ class BaselineOptimizer(object):
new_results_by_directory, baseline_name):
# This really should never happen. Just a sanity check to make sure the script fails in the case of bugs
# instead of committing incorrect baselines.
- _log.error(" %s: optimization failed" % basename)
+ _log.error(" %s: optimization failed", basename)
self.write_by_directory(results_by_directory, _log.warning, " ")
return False
- _log.debug(" %s:" % basename)
+ _log.debug(" %s:", basename)
_log.debug(" Before: ")
self.write_by_directory(results_by_directory, _log.debug, " ")
_log.debug(" After: ")
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698