Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1928873003: Use Polymer.dom with many dom manipulations. (Closed)

Created:
4 years, 7 months ago by aiolos (Not reviewing)
Modified:
4 years, 6 months ago
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Base URL:
https://github.com/catapult-project/catapult.git@polymer10-migration
Target Ref:
refs/heads/polymer10-migration
Project:
catapult
Visibility:
Public.

Description

Use Polymer.dom with many dom manipulations. BUG=catapult:#2285 NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase indent nit #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+366 lines, -318 lines) Patch
M tracing/tracing/base/base.html View 1 chunk +5 lines, -3 lines 0 comments Download
M tracing/tracing/base/unittest/html_test_results.html View 1 4 chunks +9 lines, -6 lines 0 comments Download
M tracing/tracing/base/unittest/interactive_test_runner.html View 1 4 chunks +7 lines, -6 lines 0 comments Download
M tracing/tracing/base/unittest/suite_loader.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/model/stack_frame.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/analysis_view.html View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/ui/analysis/frame_power_usage_chart.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/analysis/generic_object_view.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/analysis/memory_dump_heap_details_pane_test.html View 1 chunk +5 lines, -3 lines 0 comments Download
M tracing/tracing/ui/analysis/memory_dump_sub_view_util_test.html View 1 chunk +5 lines, -4 lines 0 comments Download
M tracing/tracing/ui/analysis/single_cpu_slice_sub_view.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/single_cpu_slice_sub_view_test.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/single_event_sub_view_test.html View 1 2 3 4 4 chunks +11 lines, -9 lines 0 comments Download
M tracing/tracing/ui/analysis/single_object_instance_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/single_object_snapshot_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/single_thread_time_slice_sub_view.html View 1 2 3 4 4 chunks +5 lines, -4 lines 0 comments Download
M tracing/tracing/ui/analysis/single_thread_time_slice_sub_view_test.html View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/analysis/stacked_pane_view.html View 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M tracing/tracing/ui/annotations/comment_box_annotation_view.html View 1 chunk +2 lines, -1 line 0 comments Download
M tracing/tracing/ui/base/bar_chart.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/chart_base.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/chart_base_2d.html View 3 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/base/container_that_decorates_its_children.html View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M tracing/tracing/ui/base/deep_utils.html View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M tracing/tracing/ui/base/deep_utils_test.html View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/base/dom_helpers.html View 1 2 3 7 chunks +11 lines, -11 lines 0 comments Download
M tracing/tracing/ui/base/dom_helpers_test.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/base/drag_handle_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/dropdown.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/base/grouping_table_groupby_picker.html View 2 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/base/hotkey_controller.html View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M tracing/tracing/ui/base/hotkey_controller_test.html View 3 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/base/info_bar.html View 1 chunk +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/base/line_chart.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/list_view.html View 1 2 3 8 chunks +12 lines, -11 lines 0 comments Download
M tracing/tracing/ui/base/mouse_mode_icon.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/base/mouse_mode_icon_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/mouse_mode_selector.html View 1 2 3 4 2 chunks +5 lines, -3 lines 0 comments Download
M tracing/tracing/ui/base/name_bar_chart.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/base/overlay.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/base/overlay_test.html View 2 chunks +6 lines, -6 lines 0 comments Download
M tracing/tracing/ui/base/pie_chart.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/resize_sensor.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/scatter_chart.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/tab_view.html View 1 2 3 4 5 chunks +8 lines, -8 lines 0 comments Download
M tracing/tracing/ui/base/tab_view_test.html View 5 chunks +21 lines, -21 lines 0 comments Download
M tracing/tracing/ui/base/table.html View 1 2 3 13 chunks +21 lines, -21 lines 0 comments Download
M tracing/tracing/ui/base/table_test.html View 2 chunks +3 lines, -2 lines 0 comments Download
M tracing/tracing/ui/base/ui.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/base/ui_test.html View 1 2 chunks +14 lines, -14 lines 0 comments Download
M tracing/tracing/ui/brushing_state_controller.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/extras/about_tracing/profiling_view.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/about_tracing/record_selection_dialog.html View 12 chunks +44 lines, -29 lines 0 comments Download
M tracing/tracing/ui/extras/about_tracing/record_selection_dialog_test.html View 3 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/display_item_debugger.html View 1 1 chunk +6 lines, -4 lines 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/display_item_list_view.html View 1 chunk +2 lines, -1 line 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/layer_picker.html View 1 chunk +2 lines, -1 line 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/layer_tree_host_impl_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/layer_tree_quad_stack_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/layer_view.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/picture_ops_chart_summary_view.html View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/picture_ops_chart_view.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/picture_ops_list_view.html View 1 3 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/picture_view.html View 1 chunk +2 lines, -1 line 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/tile_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/chrome/gpu/state_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/drive/index.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/system_stats/system_stats_instance_track.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/system_stats/system_stats_snapshot_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/scripting_control.html View 1 2 3 4 3 chunks +8 lines, -7 lines 0 comments Download
M tracing/tracing/ui/side_panel/side_panel_container.html View 3 chunks +8 lines, -8 lines 0 comments Download
M tracing/tracing/ui/timeline_track_view.html View 1 chunk +2 lines, -0 lines 0 comments Download
M tracing/tracing/ui/timeline_view.html View 4 chunks +10 lines, -7 lines 0 comments Download
M tracing/tracing/ui/timeline_view_help_overlay.html View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M tracing/tracing/ui/timeline_viewport.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/tracks/async_slice_group_track.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/tracks/chart_track.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/tracks/container_track.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/tracks/counter_track.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/tracks/cpu_track.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/tracks/device_track.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/tracks/drawing_container.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/tracks/letter_dot_track.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/tracks/model_track.html View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M tracing/tracing/ui/tracks/multi_row_track.html View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/tracks/object_instance_group_track.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/tracks/object_instance_track.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/tracks/power_series_track.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/tracks/process_track_base.html View 3 chunks +5 lines, -5 lines 0 comments Download
M tracing/tracing/ui/tracks/rect_track.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/tracks/ruler_track.html View 2 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/tracks/slice_group_track.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/tracks/spacing_track.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/tracks/stacked_bars_track.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/tracks/thread_track.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/tracks/track.html View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/ui/view_specific_brushing_state.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/value/ui/scalar_span.html View 1 chunk +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 1922863004 Patch 1

Messages

Total messages: 3 (1 generated)
charliea (OOO until 10-5)
lgtm w/ 1 nit https://codereview.chromium.org/1928873003/diff/1/tracing/tracing/ui/analysis/stacked_pane_view.html File tracing/tracing/ui/analysis/stacked_pane_view.html (right): https://codereview.chromium.org/1928873003/diff/1/tracing/tracing/ui/analysis/stacked_pane_view.html#newcode122 tracing/tracing/ui/analysis/stacked_pane_view.html:122: Polymer.dom(paneContainer).lastElementChild !== opt_parentPane) { nit: ...
4 years, 7 months ago (2016-04-28 17:04:15 UTC) #2
aiolos (Not reviewing)
4 years, 7 months ago (2016-04-28 18:01:01 UTC) #3 
https://codereview.chromium.org/1928873003/diff/1/tracing/tracing/ui/analysis...
File tracing/tracing/ui/analysis/stacked_pane_view.html (right):

https://codereview.chromium.org/1928873003/diff/1/tracing/tracing/ui/analysis...
tracing/tracing/ui/analysis/stacked_pane_view.html:122:
Polymer.dom(paneContainer).lastElementChild !== opt_parentPane) {
On 2016/04/28 17:04:15, charliea (slow) wrote:
> nit: this line should be indented one space less

Done.

Powered by Google App Engine
This is Rietveld 408576698