Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: tracing/tracing/ui/base/list_view.html

Issue 1928873003: Use Polymer.dom with many dom manipulations. (Closed) Base URL: https://github.com/catapult-project/catapult.git@polymer10-migration
Patch Set: fixes Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/ui/base/line_chart.html ('k') | tracing/tracing/ui/base/mouse_mode_icon.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/ui/base/list_view.html
diff --git a/tracing/tracing/ui/base/list_view.html b/tracing/tracing/ui/base/list_view.html
index fc49b2dd8ab453d36bca087cbcbeda48ef9afd60..451c6f3c07e2f277432cb761943650cec45aec61 100644
--- a/tracing/tracing/ui/base/list_view.html
+++ b/tracing/tracing/ui/base/list_view.html
@@ -31,7 +31,7 @@ tr.exportTo('tr.ui.b', function() {
decorate: function() {
tr.ui.b.ContainerThatDecoratesItsChildren.prototype.decorate.call(this);
- this.classList.add('x-list-view');
+ Polymer.dom(this).classList.add('x-list-view');
this.onItemClicked_ = this.onItemClicked_.bind(this);
this.onKeyDown_ = this.onKeyDown_.bind(this);
this.tabIndex = 0;
@@ -41,7 +41,7 @@ tr.exportTo('tr.ui.b', function() {
},
decorateChild_: function(item) {
- item.classList.add('list-item');
+ Polymer.dom(item).classList.add('list-item');
item.addEventListener('click', this.onItemClicked_, true);
var listView = this;
@@ -52,11 +52,12 @@ tr.exportTo('tr.ui.b', function() {
set: function(value) {
var oldSelection = listView.selectedElement;
if (oldSelection && oldSelection != this && value)
- listView.selectedElement.removeAttribute('selected');
+ Polymer.dom(listView.selectedElement).removeAttribute(
+ 'selected');
if (value)
- this.setAttribute('selected', 'selected');
+ Polymer.dom(this).setAttribute('selected', 'selected');
else
- this.removeAttribute('selected');
+ Polymer.dom(this).removeAttribute('selected');
var newSelection = listView.selectedElement;
if (newSelection != oldSelection)
tr.b.dispatchSimpleEvent(listView, 'selection-changed', false);
@@ -70,7 +71,7 @@ tr.exportTo('tr.ui.b', function() {
undecorateChild_: function(item) {
this.selectionChanged_ |= item.selected;
- item.classList.remove('list-item');
+ Polymer.dom(item).classList.remove('list-item');
item.removeEventListener('click', this.onItemClicked_);
delete item.selected;
},
@@ -118,12 +119,12 @@ tr.exportTo('tr.ui.b', function() {
onItemClicked_: function(e) {
var currentSelectedElement = this.selectedElement;
if (currentSelectedElement)
- currentSelectedElement.removeAttribute('selected');
+ Polymer.dom(currentSelectedElement).removeAttribute('selected');
var element = e.target;
while (element.parentElement != this)
element = element.parentElement;
if (element !== currentSelectedElement)
- element.setAttribute('selected', 'selected');
+ Polymer.dom(element).setAttribute('selected', 'selected');
tr.b.dispatchSimpleEvent(this, 'selection-changed', false);
},
@@ -132,7 +133,7 @@ tr.exportTo('tr.ui.b', function() {
return;
if (e.keyCode == 38) { // Up arrow.
- var prev = this.selectedElement.previousSibling;
+ var prev = Polymer.dom(this.selectedElement).previousSibling;
if (prev) {
prev.selected = true;
tr.ui.b.scrollIntoViewIfNeeded(prev);
@@ -140,7 +141,7 @@ tr.exportTo('tr.ui.b', function() {
return true;
}
} else if (e.keyCode == 40) { // Down arrow.
- var next = this.selectedElement.nextSibling;
+ var next = Polymer.dom(this.selectedElement).nextSibling;
if (next) {
next.selected = true;
tr.ui.b.scrollIntoViewIfNeeded(next);
@@ -152,7 +153,7 @@ tr.exportTo('tr.ui.b', function() {
addItem: function(textContent) {
var item = document.createElement('div');
- item.textContent = textContent;
+ Polymer.dom(item).textContent = textContent;
Polymer.dom(this).appendChild(item);
return item;
}
« no previous file with comments | « tracing/tracing/ui/base/line_chart.html ('k') | tracing/tracing/ui/base/mouse_mode_icon.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698