tracing/tracing/ui/base/grouping_table_groupby_picker.html - Issue 1928873003: Use Polymer.dom with many dom manipulations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/base/grouping_table_groupby_picker.html

Issue 1928873003: Use Polymer.dom with many dom manipulations. (Closed) Base URL: https://github.com/catapult-project/catapult.git@polymer10-migration

Patch Set: fixes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tracing/tracing/ui/base/grouping_table_groupby_picker.html

diff --git a/tracing/tracing/ui/base/grouping_table_groupby_picker.html b/tracing/tracing/ui/base/grouping_table_groupby_picker.html

index 040c270d1f4e540125db8f109a7340a00ebcb441..c8660c01a183178adeafdfc36475bae8b01631dd 100644

--- a/tracing/tracing/ui/base/grouping_table_groupby_picker.html

+++ b/tracing/tracing/ui/base/grouping_table_groupby_picker.html

@@ -128,7 +128,7 @@ tr.exportTo('tr.ui.b', function() {

this.needsInit_ = false;

- var addGroupEl = Polymer.dom(this.shadowRoot).querySelector('#add-group');

+ var addGroupEl = Polymer.dom(this.root).querySelector('#add-group');

Polymer.dom(addGroupEl.iconElement).textContent = 'Add another...';

this.currentGroupKeys = tr.b.Settings.get(

@@ -167,8 +167,8 @@ tr.exportTo('tr.ui.b', function() {

updateGroups_: function() {

- var groupsEl = Polymer.dom(this.shadowRoot).querySelector('groups');

- var addGroupEl = Polymer.dom(this.shadowRoot).querySelector('#add-group');

+ var groupsEl = Polymer.dom(this.root).querySelector('groups');

+ var addGroupEl = Polymer.dom(this.root).querySelector('#add-group');

Polymer.dom(groupsEl).textContent = '';

Polymer.dom(addGroupEl).textContent = '';

« no previous file with comments | « tracing/tracing/ui/base/dropdown.html ('k') | tracing/tracing/ui/base/hotkey_controller.html » ('j') | no next file with comments »