Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: tracing/tracing/ui/analysis/stacked_pane_view.html

Issue 1928873003: Use Polymer.dom with many dom manipulations. (Closed) Base URL: https://github.com/catapult-project/catapult.git@polymer10-migration
Patch Set: fixes Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/ui/analysis/stacked_pane_view.html
diff --git a/tracing/tracing/ui/analysis/stacked_pane_view.html b/tracing/tracing/ui/analysis/stacked_pane_view.html
index dc00028ec3daa7e66a715703bac7d9a93cabb2c1..fe0ebf9bd90b04cc467450d653876266273cebfa 100644
--- a/tracing/tracing/ui/analysis/stacked_pane_view.html
+++ b/tracing/tracing/ui/analysis/stacked_pane_view.html
@@ -118,16 +118,16 @@ Polymer({
// Remove all descendants of the parent pane (or all panes if no parent
// pane was specified) in reverse order.
- while (paneContainer.lastElementChild !== null &&
- paneContainer.lastElementChild !== opt_parentPane) {
- var removedPane = this.$.pane_container.lastElementChild;
+ while (Polymer.dom(paneContainer).lastElementChild !== null &&
+ Polymer.dom(paneContainer).lastElementChild !== opt_parentPane) {
+ var removedPane = Polymer.dom(this.$.pane_container).lastElementChild;
var listener = this.listeners_.get(removedPane);
if (listener === undefined)
throw new Error('No listener associated with pane');
this.listeners_.delete(removedPane);
removedPane.removeEventListener(
'request-child-pane-change', listener);
- paneContainer.removeChild(removedPane);
+ Polymer.dom(paneContainer).removeChild(removedPane);
}
if (opt_parentPane && opt_parentPane.parentElement !== paneContainer)
@@ -171,7 +171,7 @@ Polymer({
* panes would be rebuilt as well).
*/
rebuild: function() {
- var currentPane = this.$.pane_container.firstElementChild;
+ var currentPane = Polymer.dom(this.$.pane_container).firstElementChild;
while (currentPane) {
currentPane.rebuild();
currentPane = currentPane.nextElementSibling;
@@ -181,7 +181,7 @@ Polymer({
// For testing purposes.
get panesForTesting() {
var panes = [];
- var currentChild = this.$.pane_container.firstElementChild;
+ var currentChild = Polymer.dom(this.$.pane_container).firstElementChild;
while (currentChild) {
panes.push(currentChild);
currentChild = currentChild.nextElementSibling;

Powered by Google App Engine
This is Rietveld 408576698