tracing/tracing/ui/base/ui.html - Issue 1928873003: Use Polymer.dom with many dom manipulations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/base/ui.html

Issue 1928873003: Use Polymer.dom with many dom manipulations. (Closed) Base URL: https://github.com/catapult-project/catapult.git@polymer10-migration

Patch Set: fixes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tracing/tracing/ui/base/ui.html

diff --git a/tracing/tracing/ui/base/ui.html b/tracing/tracing/ui/base/ui.html

index 20c1bd4471db1f42376dfa59dd34b8bdc9b0d5cd..b484ef26b020e6d13d1c7d38c3da76a7a473dd56 100644

--- a/tracing/tracing/ui/base/ui.html

+++ b/tracing/tracing/ui/base/ui.html

@@ -152,10 +152,10 @@ tr.exportTo('tr.ui.b', function() {

return false;

var cur = el;

- while (cur.parentNode) {

+ while (Polymer.dom(cur).parentNode) {

if (cur == potentialParent)

return true;

- cur = cur.parentNode;

+ cur = Polymer.dom(cur).parentNode;

}

return false;

};

« no previous file with comments | « tracing/tracing/ui/base/table_test.html ('k') | tracing/tracing/ui/base/ui_test.html » ('j') | no next file with comments »