Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: tracing/tracing/base/unittest/html_test_results.html

Issue 1928873003: Use Polymer.dom with many dom manipulations. (Closed) Base URL: https://github.com/catapult-project/catapult.git@polymer10-migration
Patch Set: fixes Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/base/base.html ('k') | tracing/tracing/base/unittest/interactive_test_runner.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/base/unittest/html_test_results.html
diff --git a/tracing/tracing/base/unittest/html_test_results.html b/tracing/tracing/base/unittest/html_test_results.html
index 4769737949c69cd67e34d73e0d75b54b5cf62bb0..437ca84c983fc3c057b8608cb98cd7fc9844b36c 100644
--- a/tracing/tracing/base/unittest/html_test_results.html
+++ b/tracing/tracing/base/unittest/html_test_results.html
@@ -164,7 +164,7 @@ tr.exportTo('tr.b.unittest', function() {
}
if (this.testCaseHRef_) {
- titleEl.innerHTML = '<a href="' + this.testCaseHRef_ + '">' +
+ Polymer.dom(titleEl).innerHTML = '<a href="' + this.testCaseHRef_ + '">' +
this.testCase_.fullyQualifiedName + '</a>';
} else {
titleEl.textContent = this.testCase_.fullyQualifiedName;
@@ -175,8 +175,10 @@ tr.exportTo('tr.b.unittest', function() {
var errorEl = document.createElement('x-html-test-case-error');
Polymer.dom(errorEl).appendChild(tr.ui.b.instantiateTemplate(
'#x-html-test-case-error-template', THIS_DOC));
- errorEl.querySelector('#stack').textContent = normalizedException.stack;
- Polymer.dom(this.querySelector('#details')).appendChild(errorEl);
+ Polymer.dom(errorEl).querySelector('#stack').
+ textContent = normalizedException.stack;
+ Polymer.dom(Polymer.dom(this).querySelector('#details')).appendChild(
+ errorEl);
this.updateColorAndStatus_();
},
@@ -184,8 +186,9 @@ tr.exportTo('tr.b.unittest', function() {
var flakyEl = document.createElement('x-html-test-case-flaky');
Polymer.dom(flakyEl).appendChild(tr.ui.b.instantiateTemplate(
'#x-html-test-case-flaky-template', THIS_DOC));
- flakyEl.querySelector('#message').textContent = 'FLAKY';
- Polymer.dom(this.querySelector('#details')).appendChild(flakyEl);
+ Polymer.dom(flakyEl).querySelector('#message').textContent = 'FLAKY';
+ Polymer.dom(Polymer.dom(this).querySelector('#details')).appendChild(
+ flakyEl);
this.updateColorAndStatus_();
},
@@ -354,7 +357,7 @@ tr.exportTo('tr.b.unittest', function() {
testCaseResult.showHTMLOutput = this.showHTMLOutput_;
testCaseResult.testCase = testCase;
if ((i % 2) === 0)
- testCaseResult.classList.add('dark');
+ Polymer.dom(testCaseResult).classList.add('dark');
var href = this.getHRefForTestCase(testCase);
if (href)
« no previous file with comments | « tracing/tracing/base/base.html ('k') | tracing/tracing/base/unittest/interactive_test_runner.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698