tracing/tracing/ui/analysis/single_event_sub_view_test.html - Issue 1928873003: Use Polymer.dom with many dom manipulations.

Unified Diff: tracing/tracing/ui/analysis/single_event_sub_view_test.html

Issue 1928873003: Use Polymer.dom with many dom manipulations. (Closed) Base URL: https://github.com/catapult-project/catapult.git@polymer10-migration

Patch Set: fixes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/ui/analysis/single_cpu_slice_sub_view_test.html ('k') | tracing/tracing/ui/analysis/single_object_instance_sub_view.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/ui/analysis/single_event_sub_view_test.html

diff --git a/tracing/tracing/ui/analysis/single_event_sub_view_test.html b/tracing/tracing/ui/analysis/single_event_sub_view_test.html

index b52ebaa16bc311bf7c20023c5b548cfbdfc3d2e7..f7719a027fa8625a785f5c5096cfec03e08688e3 100644

--- a/tracing/tracing/ui/analysis/single_event_sub_view_test.html

+++ b/tracing/tracing/ui/analysis/single_event_sub_view_test.html

@@ -125,7 +125,7 @@ tr.b.unittest.testSuite(function() {

var e = tr.b.findDeepElementWithTextContent(

analysisEl, /Start Stack Trace/);

assert.isDefined(e);

- assert.isDefined(e.nextSibling.children[0].stackFrame);

+ assert.isDefined(Polymer.dom(e).nextSibling.children[0].stackFrame);

});

test('instantiate_withSingleEndStackFrame', function() {

@@ -139,8 +139,8 @@ tr.b.unittest.testSuite(function() {

var e = tr.b.findDeepElementWithTextContent(

analysisEl, /End Stack Trace/);

assert.isDefined(e);

- assert.isDefined(e.nextSibling.children[0].stackFrame);

- assert.equal(e.nextSibling.children[0].stackFrame.title, 'b2');

+ assert.isDefined(Polymer.dom(e).nextSibling.children[0].stackFrame);

+ assert.equal(Polymer.dom(e).nextSibling.children[0].stackFrame.title, 'b2');

});

test('instantiate_withDifferentStartAndEndStackFrames', function() {

@@ -155,14 +155,16 @@ tr.b.unittest.testSuite(function() {

var eA = tr.b.findDeepElementWithTextContent(

analysisEl, /Start Stack Trace/);

assert.isDefined(eA);

- assert.isDefined(eA.nextSibling.children[0].stackFrame);

- assert.equal(eA.nextSibling.children[0].stackFrame.title, 'a2');

+ assert.isDefined(Polymer.dom(eA).nextSibling.children[0].stackFrame);

+ assert.equal(Polymer.dom(eA).nextSibling.children[0].stackFrame.title,

+ 'a2');

var eB = tr.b.findDeepElementWithTextContent(

analysisEl, /End Stack Trace/);

assert.isDefined(eB);

- assert.isDefined(eB.nextSibling.children[0].stackFrame);

- assert.equal(eB.nextSibling.children[0].stackFrame.title, 'b2');

+ assert.isDefined(Polymer.dom(eB).nextSibling.children[0].stackFrame);

+ assert.equal(Polymer.dom(eB).nextSibling.children[0].stackFrame.title,

+ 'b2');

});

test('instantiate_withSameStartAndEndStackFrames', function() {

@@ -177,8 +179,8 @@ tr.b.unittest.testSuite(function() {

var e = tr.b.findDeepElementWithTextContent(

analysisEl, /Start\+End Stack Trace/);

assert.isDefined(e);

- assert.isDefined(e.nextSibling.children[0].stackFrame);

- assert.equal(e.nextSibling.children[0].stackFrame.title, 'a2');

+ assert.isDefined(Polymer.dom(e).nextSibling.children[0].stackFrame);

+ assert.equal(Polymer.dom(e).nextSibling.children[0].stackFrame.title, 'a2');

});

test('analyzeSelectionWithSingleSlice', function() {