tracing/tracing/ui/annotations/comment_box_annotation_view.html - Issue 1928873003: Use Polymer.dom with many dom manipulations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/annotations/comment_box_annotation_view.html

Issue 1928873003: Use Polymer.dom with many dom manipulations. (Closed) Base URL: https://github.com/catapult-project/catapult.git@polymer10-migration

Patch Set: fixes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tracing/tracing/ui/annotations/comment_box_annotation_view.html

diff --git a/tracing/tracing/ui/annotations/comment_box_annotation_view.html b/tracing/tracing/ui/annotations/comment_box_annotation_view.html

index e8be4588586109ef96516da1648f77a8cc43263a..172a86d77ec34d4f346ed75b7bcde768180c5b2e 100644

--- a/tracing/tracing/ui/annotations/comment_box_annotation_view.html

+++ b/tracing/tracing/ui/annotations/comment_box_annotation_view.html

@@ -33,7 +33,8 @@ tr.exportTo('tr.ui.annotations', function() {

__proto__: tr.ui.annotations.AnnotationView.prototype,

removeTextArea: function() {

- this.textArea_.parentNode.removeChild(this.textArea_);

+ Polymer.dom(Polymer.dom(this.textArea_).parentNode).removeChild(

+ this.textArea_);

draw: function(ctx) {

« no previous file with comments | « tracing/tracing/ui/analysis/stacked_pane_view.html ('k') | tracing/tracing/ui/base/bar_chart.html » ('j') | no next file with comments »