tracing/tracing/ui/extras/chrome/cc/picture_ops_list_view.html - Issue 1928873003: Use Polymer.dom with many dom manipulations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/extras/chrome/cc/picture_ops_list_view.html

Issue 1928873003: Use Polymer.dom with many dom manipulations. (Closed) Base URL: https://github.com/catapult-project/catapult.git@polymer10-migration

Patch Set: fixes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/ui/extras/chrome/cc/picture_ops_chart_view.html ('k') | tracing/tracing/ui/extras/chrome/cc/picture_view.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/ui/extras/chrome/cc/picture_ops_list_view.html

diff --git a/tracing/tracing/ui/extras/chrome/cc/picture_ops_list_view.html b/tracing/tracing/ui/extras/chrome/cc/picture_ops_list_view.html

index 2895c49ae596167b8add1ece7727770c3537b307..a95b3817f7c8b6be7e552fa1a1611927c768b74c 100644

--- a/tracing/tracing/ui/extras/chrome/cc/picture_ops_list_view.html

+++ b/tracing/tracing/ui/extras/chrome/cc/picture_ops_list_view.html

@@ -80,7 +80,7 @@ tr.exportTo('tr.ui.e.chrome.cc', function() {

// Display the element info associated with the op, if available.

if (op.elementInfo.tag || op.elementInfo.id || op.elementInfo.class) {

var elementInfo = document.createElement('span');

- elementInfo.classList.add('elementInfo');

+ Polymer.dom(elementInfo).classList.add('elementInfo');

var tag = op.elementInfo.tag ? op.elementInfo.tag : 'unknown';

var id = op.elementInfo.id ? 'id=' + op.elementInfo.id : undefined;

var className = op.elementInfo.class ? 'class=' +

@@ -104,7 +104,7 @@ tr.exportTo('tr.ui.e.chrome.cc', function() {

// Display the op timing, if available.

if (op.cmd_time && op.cmd_time >= 0.0001) {

var time = document.createElement('span');

- time.classList.add('time');

+ Polymer.dom(time).classList.add('time');

var rounded = op.cmd_time.toFixed(4);

time.textContent = '(' + rounded + 'ms)';

Polymer.dom(item).appendChild(time);

@@ -134,9 +134,9 @@ tr.exportTo('tr.ui.e.chrome.cc', function() {

beforeSelectedOp = false;

this.selectedOpIndex_ = op.opIndex;

} else if (beforeSelectedOp) {

- op.setAttribute('beforeSelection', 'beforeSelection');

+ Polymer.dom(op).setAttribute('beforeSelection', 'beforeSelection');

} else {

- op.removeAttribute('beforeSelection');

+ Polymer.dom(op).removeAttribute('beforeSelection');

}