Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: tracing/tracing/ui/analysis/memory_dump_sub_view_util_test.html

Issue 1928873003: Use Polymer.dom with many dom manipulations. (Closed) Base URL: https://github.com/catapult-project/catapult.git@polymer10-migration
Patch Set: fixes Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/ui/analysis/memory_dump_sub_view_util_test.html
diff --git a/tracing/tracing/ui/analysis/memory_dump_sub_view_util_test.html b/tracing/tracing/ui/analysis/memory_dump_sub_view_util_test.html
index 69585627461d7ce1c45b4b57a7858a231ee7cbc9..533a1cae507988ab5561dd7d61e979f67bc9820a 100644
--- a/tracing/tracing/ui/analysis/memory_dump_sub_view_util_test.html
+++ b/tracing/tracing/ui/analysis/memory_dump_sub_view_util_test.html
@@ -151,15 +151,16 @@ tr.b.unittest.testSuite(function() {
function checkCellValue(
test, value, expectedText, expectedColor, opt_expectedInfos) {
var expectedInfos = opt_expectedInfos || [];
- assert.lengthOf(value.childNodes, 1 + expectedInfos.length);
+ assert.lengthOf(Polymer.dom(value).childNodes, 1 + expectedInfos.length);
assert.strictEqual(value.style.color, expectedColor);
if (typeof expectedText === 'string')
- assert.strictEqual(value.childNodes[0].textContent, expectedText);
+ assert.strictEqual(
+ Polymer.dom(value).childNodes[0].textContent, expectedText);
else
- expectedText(value.childNodes[0]);
+ expectedText(Polymer.dom(value).childNodes[0]);
for (var i = 0; i < expectedInfos.length; i++) {
var expectedInfo = expectedInfos[i];
- var infoEl = value.childNodes[i + 1];
+ var infoEl = Polymer.dom(value).childNodes[i + 1];
assert.strictEqual(infoEl.textContent, expectedInfo.icon);
assert.strictEqual(infoEl.title, expectedInfo.message);
assert.strictEqual(infoEl.style.color, expectedInfo.color || '');

Powered by Google App Engine
This is Rietveld 408576698