Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: tracing/tracing/base/unittest/interactive_test_runner.html

Issue 1928873003: Use Polymer.dom with many dom manipulations. (Closed) Base URL: https://github.com/catapult-project/catapult.git@polymer10-migration
Patch Set: fixes Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/base/unittest/interactive_test_runner.html
diff --git a/tracing/tracing/base/unittest/interactive_test_runner.html b/tracing/tracing/base/unittest/interactive_test_runner.html
index 3ed27103a2ce615a94cbc11988d66233ea48a568..af1db3df20b96770b1b0125d2d9a0f6ca77de6b4 100644
--- a/tracing/tracing/base/unittest/interactive_test_runner.html
+++ b/tracing/tracing/base/unittest/interactive_test_runner.html
@@ -342,14 +342,14 @@ tr.exportTo('tr.b.unittest', function() {
onTestFailed_: function() {
var span = document.createElement('span');
- span.classList.add('fail');
+ Polymer.dom(span).classList.add('fail');
Polymer.dom(span).appendChild(document.createTextNode('F'));
Polymer.dom(this.querySelector('#shortform-results')).appendChild(span);
},
onTestFlaky_: function() {
var span = document.createElement('span');
- span.classList.add('flaky');
+ Polymer.dom(span).classList.add('flaky');
Polymer.dom(span).appendChild(document.createTextNode('~'));
Polymer.dom(this.querySelector('#shortform-results')).appendChild(span);
},
@@ -360,7 +360,7 @@ tr.exportTo('tr.b.unittest', function() {
var numTestsOverall = this.runner_.testCases.length;
var numTestsThatRan = stats.numTestsThatPassed +
stats.numTestsThatFailed + stats.numFlakyTests;
- statsEl.innerHTML =
+ Polymer.dom(statsEl).innerHTML =
'<span>' + numTestsThatRan + '/' + numTestsOverall +
'</span> tests run, ' +
'<span class="unittest-failed">' + stats.numTestsThatFailed +
@@ -396,7 +396,7 @@ tr.exportTo('tr.b.unittest', function() {
this.results_.removeEventListener('statschange',
this.onResultsStatsChanged_);
delete this.results_.getHRefForTestCase;
- resultsContainer.removeChild(this.results_);
+ Polymer.dom(resultsContainer).removeChild(this.results_);
}
this.results_ = new tr.b.unittest.HTMLTestResults();
@@ -611,8 +611,9 @@ tr.exportTo('tr.b.unittest', function() {
Polymer.dom(document.body).appendChild(overlay);
}
function hideLoadingOverlay() {
- var overlay = document.body.querySelector('#tests-loading-overlay');
- document.body.removeChild(overlay);
+ var overlay = Polymer.dom(document.body).querySelector(
+ '#tests-loading-overlay');
+ Polymer.dom(document.body).removeChild(overlay);
}
function updateTitle(state) {
« no previous file with comments | « tracing/tracing/base/unittest/html_test_results.html ('k') | tracing/tracing/base/unittest/suite_loader.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698