tracing/tracing/ui/analysis/single_thread_time_slice_sub_view_test.html - Issue 1928873003: Use Polymer.dom with many dom manipulations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/analysis/single_thread_time_slice_sub_view_test.html

Issue 1928873003: Use Polymer.dom with many dom manipulations. (Closed) Base URL: https://github.com/catapult-project/catapult.git@polymer10-migration

Patch Set: fixes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/ui/analysis/single_thread_time_slice_sub_view.html ('k') | tracing/tracing/ui/analysis/stacked_pane_view.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/ui/analysis/single_thread_time_slice_sub_view_test.html

diff --git a/tracing/tracing/ui/analysis/single_thread_time_slice_sub_view_test.html b/tracing/tracing/ui/analysis/single_thread_time_slice_sub_view_test.html

index 91245e9617efcc381f532c8e4ebcb33dbd0d0357..3c716f124bd357013586fe24c2c802f8c84d2ff6 100644

--- a/tracing/tracing/ui/analysis/single_thread_time_slice_sub_view_test.html

+++ b/tracing/tracing/ui/analysis/single_thread_time_slice_sub_view_test.html

@@ -57,7 +57,7 @@ tr.b.unittest.testSuite(function() {

assert.equal(e.selection[0], binderSlice);

didSelectionChangeHappen = true;

});

- view.shadowRoot.querySelector('tr-ui-a-analysis-link').click();

+ Polymer.dom(view.root).querySelector('tr-ui-a-analysis-link').click();

assert.isTrue(didSelectionChangeHappen);

});

@@ -87,7 +87,7 @@ tr.b.unittest.testSuite(function() {

assert.equal(e.selection[0], launcherSlice);

didSelectionChangeHappen = true;

});

- view.shadowRoot.querySelector('tr-ui-a-analysis-link').click();

+ Polymer.dom(view.root).querySelector('tr-ui-a-analysis-link').click();

assert.isTrue(didSelectionChangeHappen);

});