tracing/tracing/ui/extras/chrome/cc/layer_view.html - Issue 1928873003: Use Polymer.dom with many dom manipulations.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tracing/tracing/ui/extras/chrome/cc/layer_view.html

Issue 1928873003: Use Polymer.dom with many dom manipulations. (Closed) Base URL: https://github.com/catapult-project/catapult.git@polymer10-migration

Patch Set: fixes Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tracing/tracing/ui/extras/chrome/cc/layer_tree_quad_stack_view.html ('k') | tracing/tracing/ui/extras/chrome/cc/picture_ops_chart_summary_view.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <!--	2 <!--

3 Copyright (c) 2013 The Chromium Authors. All rights reserved.	3 Copyright (c) 2013 The Chromium Authors. All rights reserved.

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7	7

8 <link rel="stylesheet" href="/tracing/ui/extras/chrome/cc/layer_view.css">	8 <link rel="stylesheet" href="/tracing/ui/extras/chrome/cc/layer_view.css">

9	9

10 <link rel="import" href="/tracing/base/raf.html">	10 <link rel="import" href="/tracing/base/raf.html">

(...skipping 79 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
90 if (layer && layer.args && layer.args.pictures) {	90 if (layer && layer.args && layer.args.pictures) {

91 Polymer.dom(this.analysisEl_).appendChild(	91 Polymer.dom(this.analysisEl_).appendChild(

92 this.createPictureBtn_(layer.args.pictures));	92 this.createPictureBtn_(layer.args.pictures));

93 }	93 }

94	94

95 var analysis = selection.createAnalysis();	95 var analysis = selection.createAnalysis();

96 Polymer.dom(this.analysisEl_).appendChild(analysis);	96 Polymer.dom(this.analysisEl_).appendChild(analysis);

97 } else {	97 } else {

98 this.dragBar_.style.display = 'none';	98 this.dragBar_.style.display = 'none';

99 this.analysisEl_.style.display = 'none';	99 this.analysisEl_.style.display = 'none';

100 var analysis = this.analysisEl_.firstChild;	100 var analysis = Polymer.dom(this.analysisEl_).firstChild;

101 if (analysis)	101 if (analysis)

102 this.analysisEl_.removeChild(analysis);	102 Polymer.dom(this.analysisEl_).removeChild(analysis);

103 this.layerTreeQuadStackView_.style.height =	103 this.layerTreeQuadStackView_.style.height =

104 window.getComputedStyle(this).height;	104 window.getComputedStyle(this).height;

105 }	105 }

106 tr.b.dispatchSimpleEvent(this, 'selection-change');	106 tr.b.dispatchSimpleEvent(this, 'selection-change');

107 },	107 },

108	108

109 createPictureBtn_: function(pictures) {	109 createPictureBtn_: function(pictures) {

110 if (!(pictures instanceof Array))	110 if (!(pictures instanceof Array))

111 pictures = [pictures];	111 pictures = [pictures];

112	112

(...skipping 27 matching lines...) Expand all Loading...
140 this.layerTreeQuadStackView_.extraHighlightsByLayerId =	140 this.layerTreeQuadStackView_.extraHighlightsByLayerId =

141 extraHighlightsByLayerId;	141 extraHighlightsByLayerId;

142 }	142 }

143 };	143 };

144	144

145 return {	145 return {

146 LayerView: LayerView	146 LayerView: LayerView

147 };	147 };

148 });	148 });

149 </script>	149 </script>

OLD	NEW