tracing/tracing/ui/analysis/memory_dump_heap_details_pane_test.html - Issue 1928873003: Use Polymer.dom with many dom manipulations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/analysis/memory_dump_heap_details_pane_test.html

Issue 1928873003: Use Polymer.dom with many dom manipulations. (Closed) Base URL: https://github.com/catapult-project/catapult.git@polymer10-migration

Patch Set: fixes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/ui/analysis/generic_object_view.html ('k') | tracing/tracing/ui/analysis/memory_dump_sub_view_util_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/ui/analysis/memory_dump_heap_details_pane_test.html

diff --git a/tracing/tracing/ui/analysis/memory_dump_heap_details_pane_test.html b/tracing/tracing/ui/analysis/memory_dump_heap_details_pane_test.html

index fa2fd1d72533e0dbc15a4f9704316ba73cf5f5b7..f29400c37fccc30819696841fcefa79ac675d33d 100644

--- a/tracing/tracing/ui/analysis/memory_dump_heap_details_pane_test.html

+++ b/tracing/tracing/ui/analysis/memory_dump_heap_details_pane_test.html

@@ -220,11 +220,13 @@ tr.b.unittest.testSuite(function() {

case STACK_FRAME:

case OBJECT_TYPE:

- assert.lengthOf(formattedTitle.childNodes, 2);

- assert.strictEqual(formattedTitle.childNodes[0].textContent,

+ assert.lengthOf(Polymer.dom(formattedTitle).childNodes, 2);

+ assert.strictEqual(

+ Polymer.dom(formattedTitle).childNodes[0].textContent,

expectedDimension === STACK_FRAME ? '\u0192' : '\u24C9');

assert.strictEqual(

- formattedTitle.childNodes[1].textContent, expectedTitle);

+ Polymer.dom(formattedTitle).childNodes[1].textContent,

+ expectedTitle);

break;

default: