tracing/tracing/ui/extras/about_tracing/record_selection_dialog_test.html - Issue 1928873003: Use Polymer.dom with many dom manipulations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/extras/about_tracing/record_selection_dialog_test.html

Issue 1928873003: Use Polymer.dom with many dom manipulations. (Closed) Base URL: https://github.com/catapult-project/catapult.git@polymer10-migration

Patch Set: fixes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/ui/extras/about_tracing/record_selection_dialog.html ('k') | tracing/tracing/ui/extras/chrome/cc/display_item_debugger.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/ui/extras/about_tracing/record_selection_dialog_test.html

diff --git a/tracing/tracing/ui/extras/about_tracing/record_selection_dialog_test.html b/tracing/tracing/ui/extras/about_tracing/record_selection_dialog_test.html

index 62fa1553ab082e39ff0b307b04add4482dc09d97..b1f961bf53dd7655e0b40f3e31f2d4f19e35ac5d 100644

--- a/tracing/tracing/ui/extras/about_tracing/record_selection_dialog_test.html

+++ b/tracing/tracing/ui/extras/about_tracing/record_selection_dialog_test.html

@@ -208,7 +208,7 @@ tr.b.unittest.testSuite(function() {

assert.isFalse(dlg.useSampling);

// Make sure the manual settings are not visible.

- var classList = dlg.categoriesView_.classList;

+ var classList = Polymer.dom(dlg.categoriesView_).classList;

assert.isTrue(classList.contains('categories-column-view-hidden'));

// Verify manual settings do not modify the checkboxes.

@@ -253,7 +253,7 @@ tr.b.unittest.testSuite(function() {

assert.isFalse(dlg.useSampling);

// Make sure the manual settings are not visible.

- var classList = dlg.categoriesView_.classList;

+ var classList = Polymer.dom(dlg.categoriesView_).classList;

assert.isTrue(classList.contains('categories-column-view-hidden'));

// Switch to manual settings and verify the default values are not returned.

@@ -302,7 +302,7 @@ tr.b.unittest.testSuite(function() {

assert.isTrue(dlg.useSampling);

// Make sure the manual settings are not visible.

- var classList = dlg.categoriesView_.classList;

+ var classList = Polymer.dom(dlg.categoriesView_).classList;

assert.isTrue(classList.contains('categories-column-view-hidden'));

// Switch to manual settings and verify the default values are not returned.