tracing/tracing/ui/base/dropdown.html - Issue 1928873003: Use Polymer.dom with many dom manipulations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/base/dropdown.html

Issue 1928873003: Use Polymer.dom with many dom manipulations. (Closed) Base URL: https://github.com/catapult-project/catapult.git@polymer10-migration

Patch Set: fixes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tracing/tracing/ui/base/dropdown.html

diff --git a/tracing/tracing/ui/base/dropdown.html b/tracing/tracing/ui/base/dropdown.html

index df9099f82f8f9621935d190e1f197af5a4a65e34..5c2f4dfe170a93e5a61bf150611ab957c8d7ea68 100644

--- a/tracing/tracing/ui/base/dropdown.html

+++ b/tracing/tracing/ui/base/dropdown.html

@@ -118,7 +118,7 @@ Polymer({

if (this.isOpen)

return;

- this.$.outer.classList.add('open');

+ Polymer.dom(this.$.outer).classList.add('open');

var ddr = this.$.outer.getBoundingClientRect();

var rW = Math.max(ddr.width, 150);

@@ -149,7 +149,7 @@ Polymer({

if (!this.isOpen)

return;

this.$.dialog.close();

- this.$.outer.classList.remove('open');

+ Polymer.dom(this.$.outer).classList.remove('open');

this.$.outer.focus();

« no previous file with comments | « tracing/tracing/ui/base/drag_handle_test.html ('k') | tracing/tracing/ui/base/grouping_table_groupby_picker.html » ('j') | no next file with comments »