tracing/tracing/model/stack_frame.html - Issue 1928873003: Use Polymer.dom with many dom manipulations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/model/stack_frame.html

Issue 1928873003: Use Polymer.dom with many dom manipulations. (Closed) Base URL: https://github.com/catapult-project/catapult.git@polymer10-migration

Patch Set: fixes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tracing/tracing/model/stack_frame.html

diff --git a/tracing/tracing/model/stack_frame.html b/tracing/tracing/model/stack_frame.html

index 50f3126a1e5126db63eacfd685c3983f9843f258..6063ea2b5283b194d4407a02647ad75367499585 100644

--- a/tracing/tracing/model/stack_frame.html

+++ b/tracing/tracing/model/stack_frame.html

@@ -55,7 +55,7 @@ tr.exportTo('tr.model', function() {

set parentFrame(parentFrame) {

if (this.parentFrame_)

- this.parentFrame_.removeChild(this);

+ Polymer.dom(this.parentFrame_).removeChild(this);

this.parentFrame_ = parentFrame;

if (this.parentFrame_)

this.parentFrame_.addChild(this);

« no previous file with comments | « tracing/tracing/base/unittest/suite_loader.html ('k') | tracing/tracing/ui/analysis/analysis_view.html » ('j') | no next file with comments »