tracing/tracing/ui/extras/chrome/cc/picture_ops_chart_summary_view.html - Issue 1928873003: Use Polymer.dom with many dom manipulations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/extras/chrome/cc/picture_ops_chart_summary_view.html

Issue 1928873003: Use Polymer.dom with many dom manipulations. (Closed) Base URL: https://github.com/catapult-project/catapult.git@polymer10-migration

Patch Set: fixes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/ui/extras/chrome/cc/layer_view.html ('k') | tracing/tracing/ui/extras/chrome/cc/picture_ops_chart_view.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/ui/extras/chrome/cc/picture_ops_chart_summary_view.html

diff --git a/tracing/tracing/ui/extras/chrome/cc/picture_ops_chart_summary_view.html b/tracing/tracing/ui/extras/chrome/cc/picture_ops_chart_summary_view.html

index d9db1966e6b7a5be0a2a1b82270af28764892526..c9d60769fdc9b9afe24ab1a023ad973f15919a67 100644

--- a/tracing/tracing/ui/extras/chrome/cc/picture_ops_chart_summary_view.html

+++ b/tracing/tracing/ui/extras/chrome/cc/picture_ops_chart_summary_view.html

@@ -78,7 +78,7 @@ tr.exportTo('tr.ui.e.chrome.cc', function() {

this.picture_ = picture;

this.pictureDataProcessed_ = false;

- if (this.classList.contains('hidden'))

+ if (Polymer.dom(this).classList.contains('hidden'))

return;

this.processPictureData_();

@@ -87,12 +87,12 @@ tr.exportTo('tr.ui.e.chrome.cc', function() {

hide: function() {

- this.classList.add('hidden');

+ Polymer.dom(this).classList.add('hidden');

show: function() {

- this.classList.remove('hidden');

+ Polymer.dom(this).classList.remove('hidden');

if (this.pictureDataProcessed_)

return;