tracing/tracing/ui/base/container_that_decorates_its_children.html - Issue 1928873003: Use Polymer.dom with many dom manipulations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/base/container_that_decorates_its_children.html

Issue 1928873003: Use Polymer.dom with many dom manipulations. (Closed) Base URL: https://github.com/catapult-project/catapult.git@polymer10-migration

Patch Set: fixes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tracing/tracing/ui/base/container_that_decorates_its_children.html

diff --git a/tracing/tracing/ui/base/container_that_decorates_its_children.html b/tracing/tracing/ui/base/container_that_decorates_its_children.html

index 0ee972ef03ea0d5dea1da4066b9eef3da08ca4bc..015179c031718d18cd4c90c4a71605b8f343e4c2 100644

--- a/tracing/tracing/ui/base/container_that_decorates_its_children.html

+++ b/tracing/tracing/ui/base/container_that_decorates_its_children.html

@@ -62,7 +62,8 @@ tr.exportTo('tr.ui.b', function() {

clear: function() {

while (this.lastChild)

- HTMLDivElement.prototype.removeChild.call(this, this.lastChild);

+ HTMLDivElement.prototype.removeChild.call(

+ this, Polymer.dom(this).lastChild);

this.didMutate_(this.observer_.takeRecords());

« no previous file with comments | « tracing/tracing/ui/base/chart_base_2d.html ('k') | tracing/tracing/ui/base/deep_utils.html » ('j') | no next file with comments »