tracing/tracing/ui/timeline_viewport.html - Issue 1928873003: Use Polymer.dom with many dom manipulations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/timeline_viewport.html

Issue 1928873003: Use Polymer.dom with many dom manipulations. (Closed) Base URL: https://github.com/catapult-project/catapult.git@polymer10-migration

Patch Set: fixes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tracing/tracing/ui/timeline_viewport.html

diff --git a/tracing/tracing/ui/timeline_viewport.html b/tracing/tracing/ui/timeline_viewport.html

index 0f5cf76b99309f63485b2b850e0c6cfa99379475..996ad8d7de070bc512d6bb04f2e4a069bc4d9413 100644

--- a/tracing/tracing/ui/timeline_viewport.html

+++ b/tracing/tracing/ui/timeline_viewport.html

@@ -157,7 +157,7 @@ tr.exportTo('tr.ui', function() {

}

if (this.iframe_) {

this.iframe_.removeEventListener('resize', this.onResize_);

- this.parentEl_.removeChild(this.iframe_);

+ Polymer.dom(this.parentEl_).removeChild(this.iframe_);

}

« no previous file with comments | « tracing/tracing/ui/timeline_view_help_overlay.html ('k') | tracing/tracing/ui/tracks/async_slice_group_track.html » ('j') | no next file with comments »