Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1862373003: Rename EmitArgs::fSamplers to fTexSamplers (Closed)

Created:
4 years, 8 months ago by Chris Dalton
Modified:
4 years, 8 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@upload3_infer
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Rename EmitArgs::fSamplers to fTexSamplers Renames fSamplers to fTexSamplers in GrProcessor EmitArgs, and renames GrGLSLTextureSampler to GrGLSLSampler. This will allow us to add a second array of buffer samplers. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1862373003 Committed: https://skia.googlesource.com/skia/+/3f6f76f98b6b37d17d1492791ff0feb1b7586bd6

Patch Set 1 #

Patch Set 2 : alphabetize headers #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -156 lines) Patch
M experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M gyp/gpu.gypi View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkLightingShader.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/GrCircleBlurFragmentProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrTextureDomain.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrYUVEffect.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/glsl/GrGLSLFragmentProcessor.h View 5 chunks +6 lines, -5 lines 0 comments Download
M src/gpu/glsl/GrGLSLFragmentProcessor.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/glsl/GrGLSLPrimitiveProcessor.h View 5 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/glsl/GrGLSLProgramBuilder.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/glsl/GrGLSLProgramBuilder.cpp View 8 chunks +11 lines, -11 lines 0 comments Download
A + src/gpu/glsl/GrGLSLSampler.h View 1 chunk +9 lines, -9 lines 0 comments Download
M src/gpu/glsl/GrGLSLShaderBuilder.h View 2 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/glsl/GrGLSLShaderBuilder.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
D src/gpu/glsl/GrGLSLTextureSampler.h View 1 chunk +0 lines, -35 lines 0 comments Download
M src/gpu/glsl/GrGLSLXferProcessor.h View 5 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/glsl/GrGLSLXferProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1846963004 Patch 190001

Dependent Patchsets:

Issue 1869063005 Patch 60001

Messages

Total messages: 12 (7 generated)
Chris Dalton
4 years, 8 months ago (2016-04-08 00:22:55 UTC) #3
bsalomon
lgtm
4 years, 8 months ago (2016-04-11 13:27:26 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 1846963004 Patch 150001). Please resolve the dependency and ...
4 years, 8 months ago (2016-04-11 18:19:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862373003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862373003/40001
4 years, 8 months ago (2016-04-11 19:04:32 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 19:18:15 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/3f6f76f98b6b37d17d1492791ff0feb1b7586bd6

Powered by Google App Engine
This is Rietveld 408576698