Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1869063005: Add GLSL support for texelFetch (Closed)

Created:
4 years, 8 months ago by Chris Dalton
Modified:
4 years, 8 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@upload_renaem
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add GLSL support for texelFetch Adds a cap and builder methods for texelFetch. This is required for texel buffers. Also moves the texel buffer cap into the general shader caps, and adds glTexBufferRange to the GL interface. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1869063005 Committed: https://skia.googlesource.com/skia/+/f8a6ce8d8c54cab5456d3099fa07e460c889c2e6

Patch Set 1 #

Patch Set 2 : comments #

Patch Set 3 : comment again #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -30 lines) Patch
M include/gpu/GrCaps.h View 2 chunks +2 lines, -0 lines 0 comments Download
M include/gpu/gl/GrGLFunctions.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrCaps.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +20 lines, -11 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M src/gpu/glsl/GrGLSLCaps.h View 4 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/glsl/GrGLSLCaps.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/glsl/GrGLSLShaderBuilder.h View 1 2 3 4 3 chunks +15 lines, -1 line 0 comments Download
M src/gpu/glsl/GrGLSLShaderBuilder.cpp View 1 2 3 4 2 chunks +28 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
Chris Dalton
4 years, 8 months ago (2016-04-08 00:25:40 UTC) #3
bsalomon
lgtm
4 years, 8 months ago (2016-04-11 19:51:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869063005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869063005/80001
4 years, 8 months ago (2016-04-11 19:52:03 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 20:02:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/f8a6ce8d8c54cab5456d3099fa07e460c889c2e6

Powered by Google App Engine
This is Rietveld 408576698