Infer sampler precision from pixel config

Infer sampler precision from pixel config

Adds a "samplerPrecision" method to GrGLSLCaps and updates
GrGLSLProgramBuilder to infer a sampler's precision based on its
config and visibility.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1846963004

Committed: https://skia.googlesource.com/skia/+/a6b92ad1f7b79106caef6a4c721903544f507a02

[Chris Dalton, 2016-04-01 22:07:53]

Description was changed from

==========
Infer sampler precision from pixel config

Updates GrGLSLProgramBuilder to infer a sampler's precision based on
its config, and begins including sampler precision in program keys.

BUG=skia:
==========

to

==========
Infer sampler precision from pixel config

Updates GrGLSLProgramBuilder to infer a sampler's precision based on
its config, and begins including sampler precision in program keys.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Chris Dalton, 2016-04-01 22:14:13]

cdalton@nvidia.com changed reviewers:
+ bsalomon@google.com

[bsalomon, 2016-04-04 13:00:01]

Can we make this dependent upon having variable precision? The caps has that
information. On GPUs where low, medium, and high are all float32 I'd prefer not
to generate extraneous shaders. Also, most GPUs have low==medium.

[Chris Dalton, 2016-04-05 20:36:56]

cdalton@nvidia.com changed reviewers:
+ egdaniel@google.com

[Chris Dalton, 2016-04-05 20:36:57]

Patchset 2 should never cause us to generate an extraneous shader.

[Chris Dalton, 2016-04-05 20:37:14]

(Added Greg for the VkCaps stuff)

[Chris Dalton, 2016-04-05 20:39:40]

Description was changed from

==========
Infer sampler precision from pixel config

Updates GrGLSLProgramBuilder to infer a sampler's precision based on
its config, and begins including sampler precision in program keys.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Infer sampler precision from pixel config

Updates GrGLSLProgramBuilder to infer a sampler's precision based on
its config. Adds an "effectiveFloatPrecision" method to GrShaderCaps
and uses it to include sampler precision in program keys.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[egdaniel, 2016-04-05 21:09:48]

https://codereview.chromium.org/1846963004/diff/10001/src/gpu/vk/GrVkCaps.cpp
File src/gpu/vk/GrVkCaps.cpp (right):

https://codereview.chromium.org/1846963004/diff/10001/src/gpu/vk/GrVkCaps.cpp...
src/gpu/vk/GrVkCaps.cpp:158: for (int s = 0; s < kGrShaderTypeCount; ++s) {
in vulkan/SPIR-V,

highp in glsl maps to 32 bit float t IEEE 754 floating-point.
lowp/mediump maps to RelexedPrecision, see SPIR-V spec
(https://www.khronos.org/registry/spir-v/specs/1.0/SPIRV.pdf) for minimum
requirements for this precsion.

[Chris Dalton, 2016-04-05 21:54:49]

https://codereview.chromium.org/1846963004/diff/10001/src/gpu/vk/GrVkCaps.cpp
File src/gpu/vk/GrVkCaps.cpp (right):

https://codereview.chromium.org/1846963004/diff/10001/src/gpu/vk/GrVkCaps.cpp...
src/gpu/vk/GrVkCaps.cpp:158: for (int s = 0; s < kGrShaderTypeCount; ++s) {
On 2016/04/05 21:09:48, egdaniel wrote:
> in vulkan/SPIR-V,
> 
> highp in glsl maps to 32 bit float t IEEE 754 floating-point.
> lowp/mediump maps to RelexedPrecision, see SPIR-V spec
> (https://www.khronos.org/registry/spir-v/specs/1.0/SPIRV.pdf) for minimum
> requirements for this precsion.

Done.

[egdaniel, 2016-04-06 13:16:23]

vulkan stuff looks fine to me

[bsalomon, 2016-04-06 13:35:56]

https://codereview.chromium.org/1846963004/diff/110001/include/gpu/GrCaps.h
File include/gpu/GrCaps.h (right):

https://codereview.chromium.org/1846963004/diff/110001/include/gpu/GrCaps.h#n...
include/gpu/GrCaps.h:85: GrSLPrecision effectiveFloatPrecision(GrShaderType
shaderType, GrSLPrecision precision) const {
It still feels odd to me that we have a precooked table with SLPrecision values
for PixelConfigs. Are they based on the min specifications for precision
qualifiers in the ES2 spec? That would make me feel better about it. But then
I'd also think that it shouldn't be a global function but backend dependent
(that is, make this function take the config rather than a precision from a
global table).

[Chris Dalton, 2016-04-06 21:37:08]

On 2016/04/06 13:35:56, bsalomon wrote:
> https://codereview.chromium.org/1846963004/diff/110001/include/gpu/GrCaps.h
> File include/gpu/GrCaps.h (right):
> 
>
https://codereview.chromium.org/1846963004/diff/110001/include/gpu/GrCaps.h#n...
> include/gpu/GrCaps.h:85: GrSLPrecision effectiveFloatPrecision(GrShaderType
> shaderType, GrSLPrecision precision) const {
> It still feels odd to me that we have a precooked table with SLPrecision
values
> for PixelConfigs. Are they based on the min specifications for precision
> qualifiers in the ES2 spec? That would make me feel better about it. But then
> I'd also think that it shouldn't be a global function but backend dependent
> (that is, make this function take the config rather than a precision from a
> global table).

Moved the table into the caps. I like this version better.

[Chris Dalton, 2016-04-06 23:33:26]

Description was changed from

==========
Infer sampler precision from pixel config

Updates GrGLSLProgramBuilder to infer a sampler's precision based on
its config. Adds an "effectiveFloatPrecision" method to GrShaderCaps
and uses it to include sampler precision in program keys.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Infer sampler precision from pixel config

Adds a "samplerPrecision" method to GrGLSLCaps and updates
GrGLSLProgramBuilder to infer a sampler's precision based on its
config and visibility.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-04-11 13:23:18]

lgtm

[Chris Dalton, 2016-04-11 18:18:42]

The CQ bit was checked by cdalton@nvidia.com

[commit-bot: I haz the power, 2016-04-11 18:18:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1846963004/150001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1846963004/150001

[commit-bot: I haz the power, 2016-04-11 18:23:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-11 18:23:57]

Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[Chris Dalton, 2016-04-11 18:41:04]

The CQ bit was checked by cdalton@nvidia.com

[Chris Dalton, 2016-04-11 18:41:05]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1846963004/#ps170001
(title: "msvc apparently does not support constexpr")

[commit-bot: I haz the power, 2016-04-11 18:41:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1846963004/170001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1846963004/170001

[commit-bot: I haz the power, 2016-04-11 18:43:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-11 18:43:30]

Try jobs failed on following builders:
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)

[Chris Dalton, 2016-04-11 18:48:36]

The CQ bit was checked by cdalton@nvidia.com

[Chris Dalton, 2016-04-11 18:48:36]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1846963004/#ps190001
(title: "... and gcc doesn't like the enums")

[commit-bot: I haz the power, 2016-04-11 18:48:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1846963004/190001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1846963004/190001

[commit-bot: I haz the power, 2016-04-11 19:03:10]

Description was changed from

==========
Infer sampler precision from pixel config

Adds a "samplerPrecision" method to GrGLSLCaps and updates
GrGLSLProgramBuilder to infer a sampler's precision based on its
config and visibility.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Infer sampler precision from pixel config

Adds a "samplerPrecision" method to GrGLSLCaps and updates
GrGLSLProgramBuilder to infer a sampler's precision based on its
config and visibility.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/a6b92ad1f7b79106caef6a4c721903544f507a02
==========

[commit-bot: I haz the power, 2016-04-11 19:03:11]

Committed patchset #11 (id:190001) as
https://skia.googlesource.com/skia/+/a6b92ad1f7b79106caef6a4c721903544f507a02