Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1831133004: Revert of Consolidate GPU buffer implementations (Closed)

Created:
4 years, 9 months ago by robertphillips
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Consolidate GPU buffer implementations (patchset #10 id:180001 of https://codereview.chromium.org/1825393002/ ) Reason for revert: Lots of Android redness Original issue's description: > Consolidate GPU buffer implementations > > Consolidates all the different buffer implementations into a single > GrBuffer class. This will allow us to add new buffer types, use DSA in > OpenGL, track buffer bindings by unique ID, cache buffers without > respect to the type of data they have been used for previously, etc. > This change is strictly a refactor; it introduces no change in > functionality. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1825393002 > > Committed: https://skia.googlesource.com/skia/+/8b1bff29675afd25843439eade634a57f68fe16f TBR=bsalomon@google.com,egdaniel@google.com,jvanverth@google.com,cdalton@nvidia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/f8c3ba40cf4f42b2c2ba1b473c28d7733383223e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1437 lines, -834 lines) Patch
M gyp/gpu.gypi View 8 chunks +12 lines, -3 lines 0 comments Download
M include/gpu/GrCaps.h View 2 chunks +4 lines, -4 lines 0 comments Download
M include/gpu/GrContextOptions.h View 2 chunks +2 lines, -2 lines 0 comments Download
M include/gpu/GrTypesPriv.h View 1 chunk +7 lines, -23 lines 0 comments Download
M src/gpu/GrBatchAtlas.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrBatchFlushState.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrBatchFlushState.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
D src/gpu/GrBuffer.h View 1 chunk +0 lines, -145 lines 0 comments Download
M src/gpu/GrBufferAllocPool.h View 7 chunks +25 lines, -12 lines 0 comments Download
M src/gpu/GrBufferAllocPool.cpp View 12 chunks +28 lines, -17 lines 0 comments Download
M src/gpu/GrCaps.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawTarget.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A src/gpu/GrGeometryBuffer.h View 1 chunk +124 lines, -0 lines 0 comments Download
M src/gpu/GrGpu.h View 6 chunks +53 lines, -21 lines 0 comments Download
M src/gpu/GrGpu.cpp View 4 chunks +27 lines, -10 lines 0 comments Download
A src/gpu/GrIndexBuffer.h View 1 chunk +51 lines, -0 lines 0 comments Download
M src/gpu/GrMesh.h View 6 chunks +11 lines, -11 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrResourceProvider.h View 6 chunks +30 lines, -19 lines 0 comments Download
M src/gpu/GrResourceProvider.cpp View 4 chunks +64 lines, -22 lines 0 comments Download
M src/gpu/GrSoftwarePathRenderer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrTest.cpp View 3 chunks +7 lines, -3 lines 0 comments Download
A src/gpu/GrTransferBuffer.h View 1 chunk +76 lines, -0 lines 0 comments Download
A src/gpu/GrVertexBuffer.h View 1 chunk +42 lines, -0 lines 0 comments Download
M src/gpu/batches/GrAAConvexPathRenderer.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/batches/GrAADistanceFieldPathRenderer.cpp View 4 chunks +5 lines, -6 lines 0 comments Download
M src/gpu/batches/GrAAFillRectBatch.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrAAHairLinePathRenderer.cpp View 5 chunks +8 lines, -7 lines 0 comments Download
M src/gpu/batches/GrAALinearizingConvexPathRenderer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrAAStrokeRectBatch.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/batches/GrAtlasTextBatch.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrAtlasTextBatch.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/batches/GrDefaultPathRenderer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrDrawVerticesBatch.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrNinePatch.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrNonAAFillRectBatch.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrNonAAStrokeRectBatch.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrPLSPathRenderer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/batches/GrTInstanceBatch.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrTessellatingPathRenderer.cpp View 5 chunks +8 lines, -7 lines 0 comments Download
M src/gpu/batches/GrTestBatch.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/batches/GrVertexBatch.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrVertexBatch.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 chunk +1 line, -0 lines 0 comments Download
D src/gpu/gl/GrGLBuffer.h View 1 chunk +0 lines, -61 lines 0 comments Download
D src/gpu/gl/GrGLBuffer.cpp View 1 chunk +0 lines, -336 lines 0 comments Download
A src/gpu/gl/GrGLBufferImpl.h View 1 chunk +69 lines, -0 lines 0 comments Download
A src/gpu/gl/GrGLBufferImpl.cpp View 1 chunk +122 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLDefines.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 6 chunks +18 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 7 chunks +226 lines, -15 lines 0 comments Download
A src/gpu/gl/GrGLIndexBuffer.h View 1 chunk +48 lines, -0 lines 0 comments Download
A src/gpu/gl/GrGLIndexBuffer.cpp View 1 chunk +60 lines, -0 lines 0 comments Download
A src/gpu/gl/GrGLTransferBuffer.h View 1 chunk +48 lines, -0 lines 0 comments Download
A src/gpu/gl/GrGLTransferBuffer.cpp View 1 chunk +51 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLVertexArray.h View 1 chunk +2 lines, -0 lines 0 comments Download
A src/gpu/gl/GrGLVertexBuffer.h View 1 chunk +48 lines, -0 lines 0 comments Download
A src/gpu/gl/GrGLVertexBuffer.cpp View 1 chunk +60 lines, -0 lines 0 comments Download
M src/gpu/vk/GrVkCaps.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/vk/GrVkGpu.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/vk/GrVkGpu.cpp View 2 chunks +14 lines, -23 lines 0 comments Download
M src/gpu/vk/GrVkIndexBuffer.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/vk/GrVkIndexBuffer.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/vk/GrVkTransferBuffer.h View 3 chunks +7 lines, -10 lines 0 comments Download
M src/gpu/vk/GrVkTransferBuffer.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/gpu/vk/GrVkVertexBuffer.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/vk/GrVkVertexBuffer.cpp View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
robertphillips
Created Revert of Consolidate GPU buffer implementations
4 years, 9 months ago (2016-03-25 11:55:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831133004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831133004/1
4 years, 9 months ago (2016-03-25 11:55:37 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 11:56:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f8c3ba40cf4f42b2c2ba1b473c28d7733383223e

Powered by Google App Engine
This is Rietveld 408576698