Make calls to AtomicString(const String&) explicit in svg/

Make calls to AtomicString(const String&) explicit in svg/

Make calls to AtomicString(const String&) explicit in svg/ and avoid
useless conversions from String to AtomicString when possible.

This is one step towards making the AtomicString(const String&) constructor
explicit. This CL takes care only of the svg/ part so that it is more
easily reviewable.

R=eseidel
BUG=323739
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164412

[eseidel, 2014-01-01 01:42:06]

rslgtm.

https://codereview.chromium.org/121173004/diff/1/Source/core/rendering/svg/Re...
File Source/core/rendering/svg/ReferenceFilterBuilder.cpp (right):

https://codereview.chromium.org/121173004/diff/1/Source/core/rendering/svg/Re...
Source/core/rendering/svg/ReferenceFilterBuilder.cpp:85: RefPtr<CSSValue>
cssValue =
svgElement->getPresentationAttribute(AtomicString(SVGNames::color_interpolation_filtersAttr.toString()));
Wat?

https://codereview.chromium.org/121173004/diff/1/Source/core/rendering/svg/Re...
Source/core/rendering/svg/ReferenceFilterBuilder.cpp:128: Element* filter =
document->getElementById(AtomicString(filterOperation->fragment()));
It seems fragment wants to be an AtomicString?

https://codereview.chromium.org/121173004/diff/1/Source/core/rendering/svg/SV...
File Source/core/rendering/svg/SVGRenderTreeAsText.cpp (right):

https://codereview.chromium.org/121173004/diff/1/Source/core/rendering/svg/SV...
Source/core/rendering/svg/SVGRenderTreeAsText.cpp:629: if
(RenderSVGResourceMasker* masker =
getRenderSVGResourceById<RenderSVGResourceMasker>(object.document(),
AtomicString(svgStyle->maskerResource()))) {
I should have made all of these AtomicSTrings n SVGRenderStyle long ago.

https://codereview.chromium.org/121173004/diff/1/Source/core/rendering/svg/SV...
File Source/core/rendering/svg/SVGResources.cpp (right):

https://codereview.chromium.org/121173004/diff/1/Source/core/rendering/svg/SV...
Source/core/rendering/svg/SVGResources.cpp:175: id =
AtomicString(SVGURIReference::fragmentIdentifierFromIRIString(paintUri,
document));
Again, fragments seem to always ben AtomicStrings.

[Inactive, 2014-01-01 16:12:59]

https://codereview.chromium.org/121173004/diff/1/Source/core/rendering/svg/Re...
File Source/core/rendering/svg/ReferenceFilterBuilder.cpp (right):

https://codereview.chromium.org/121173004/diff/1/Source/core/rendering/svg/Re...
Source/core/rendering/svg/ReferenceFilterBuilder.cpp:85: RefPtr<CSSValue>
cssValue =
svgElement->getPresentationAttribute(AtomicString(SVGNames::color_interpolation_filtersAttr.toString()));
On 2014/01/01 01:42:07, eseidel wrote:
> Wat?

We have a QualifiedName object and we need to get an AtomicString. While the
QualifiedName members (prefix, localName) are stored as AtomicStrings, the
QualifiedName::toString() method concatenates them and returns a String. If this
is a common use case, we might want to add a QualifiedName::toAtomicString()
method. Based on the code I have updated, I am not convinced this is common
though.

https://codereview.chromium.org/121173004/diff/1/Source/core/rendering/svg/Re...
Source/core/rendering/svg/ReferenceFilterBuilder.cpp:128: Element* filter =
document->getElementById(AtomicString(filterOperation->fragment()));
On 2014/01/01 01:42:07, eseidel wrote:
> It seems fragment wants to be an AtomicString?

Done.

https://codereview.chromium.org/121173004/diff/1/Source/core/rendering/svg/SV...
File Source/core/rendering/svg/SVGRenderTreeAsText.cpp (right):

https://codereview.chromium.org/121173004/diff/1/Source/core/rendering/svg/SV...
Source/core/rendering/svg/SVGRenderTreeAsText.cpp:629: if
(RenderSVGResourceMasker* masker =
getRenderSVGResourceById<RenderSVGResourceMasker>(object.document(),
AtomicString(svgStyle->maskerResource()))) {
On 2014/01/01 01:42:07, eseidel wrote:
> I should have made all of these AtomicSTrings n SVGRenderStyle long ago.

Done.

https://codereview.chromium.org/121173004/diff/1/Source/core/rendering/svg/SV...
File Source/core/rendering/svg/SVGResources.cpp (right):

https://codereview.chromium.org/121173004/diff/1/Source/core/rendering/svg/SV...
Source/core/rendering/svg/SVGResources.cpp:175: id =
AtomicString(SVGURIReference::fragmentIdentifierFromIRIString(paintUri,
document));
On 2014/01/01 01:42:07, eseidel wrote:
> Again, fragments seem to always ben AtomicStrings.

Done.

[commit-bot: I haz the power, 2014-01-01 16:15:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/121173004/70002

[commit-bot: I haz the power, 2014-01-01 17:26:05]

Change committed as 164412