Source/core/svg/SVGFEOffsetElement.cpp - Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGFEOffsetElement.cpp

Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take feedback into consideration Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGFEOffsetElement.cpp

diff --git a/Source/core/svg/SVGFEOffsetElement.cpp b/Source/core/svg/SVGFEOffsetElement.cpp

index 7b29b59b8a4c40c8511633fc2aae00c3353662b7..0db30a80797c2ff61a5bf3c66ae412e1dda6164a 100644

--- a/Source/core/svg/SVGFEOffsetElement.cpp

+++ b/Source/core/svg/SVGFEOffsetElement.cpp

@@ -108,7 +108,7 @@ void SVGFEOffsetElement::svgAttributeChanged(const QualifiedName& attrName)

PassRefPtr<FilterEffect> SVGFEOffsetElement::build(SVGFilterBuilder* filterBuilder, Filter* filter)

{

- FilterEffect* input1 = filterBuilder->getEffectById(in1CurrentValue());

+ FilterEffect* input1 = filterBuilder->getEffectById(AtomicString(in1CurrentValue()));

if (!input1)

return 0;

« no previous file with comments | « Source/core/svg/SVGFEMorphologyElement.cpp ('k') | Source/core/svg/SVGFESpecularLightingElement.cpp » ('j') | no next file with comments »