Source/core/svg/SVGAltGlyphElement.h - Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/svg/SVGAltGlyphElement.h

Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take feedback into consideration Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/core/svg/SVGAltGlyphDefElement.cpp ('k') | Source/core/svg/SVGAltGlyphElement.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>	2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>

3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>	3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>

4 * Copyright (C) 2008 Apple Inc. All rights reserved.	4 * Copyright (C) 2008 Apple Inc. All rights reserved.

5 *	5 *

6 * This library is free software; you can redistribute it and/or	6 * This library is free software; you can redistribute it and/or

7 * modify it under the terms of the GNU Library General Public	7 * modify it under the terms of the GNU Library General Public

8 * License as published by the Free Software Foundation; either	8 * License as published by the Free Software Foundation; either

9 * version 2 of the License, or (at your option) any later version.	9 * version 2 of the License, or (at your option) any later version.

10 *	10 *

(...skipping 24 matching lines...) Expand all Loading...
35 class SVGAltGlyphElement FINAL : public SVGTextPositioningElement,	35 class SVGAltGlyphElement FINAL : public SVGTextPositioningElement,

36 public SVGURIReference {	36 public SVGURIReference {

37 public:	37 public:

38 static PassRefPtr<SVGAltGlyphElement> create(Document&);	38 static PassRefPtr<SVGAltGlyphElement> create(Document&);

39	39

40 const AtomicString& glyphRef() const;	40 const AtomicString& glyphRef() const;

41 void setGlyphRef(const AtomicString&, ExceptionState&);	41 void setGlyphRef(const AtomicString&, ExceptionState&);

42 const AtomicString& format() const;	42 const AtomicString& format() const;

43 void setFormat(const AtomicString&, ExceptionState&);	43 void setFormat(const AtomicString&, ExceptionState&);

44	44

45 bool hasValidGlyphElements(Vector<String>& glyphNames) const;	45 bool hasValidGlyphElements(Vector<AtomicString>& glyphNames) const;

46	46

47 private:	47 private:

48 explicit SVGAltGlyphElement(Document&);	48 explicit SVGAltGlyphElement(Document&);

49	49

50 virtual RenderObject* createRenderer(RenderStyle*);	50 virtual RenderObject* createRenderer(RenderStyle*);

51 virtual bool childShouldCreateRenderer(const Node& child) const;	51 virtual bool childShouldCreateRenderer(const Node& child) const;

52	52

53 BEGIN_DECLARE_ANIMATED_PROPERTIES(SVGAltGlyphElement)	53 BEGIN_DECLARE_ANIMATED_PROPERTIES(SVGAltGlyphElement)

54 DECLARE_ANIMATED_STRING(Href, href)	54 DECLARE_ANIMATED_STRING(Href, href)

55 END_DECLARE_ANIMATED_PROPERTIES	55 END_DECLARE_ANIMATED_PROPERTIES

56 };	56 };

57	57

58 } // namespace WebCore	58 } // namespace WebCore

59	59

60 #endif	60 #endif

61 #endif	61 #endif

OLD	NEW