Source/core/css/resolver/FilterOperationResolver.cpp - Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/FilterOperationResolver.cpp

Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take feedback into consideration Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/resolver/FilterOperationResolver.cpp

diff --git a/Source/core/css/resolver/FilterOperationResolver.cpp b/Source/core/css/resolver/FilterOperationResolver.cpp

index e163829f8aa9aabf473ad02ffa66ae1e3baff3bb..30d6cdc5b4011a4b64af0619a221a1f9127c429d 100644

--- a/Source/core/css/resolver/FilterOperationResolver.cpp

+++ b/Source/core/css/resolver/FilterOperationResolver.cpp

@@ -397,7 +397,7 @@ bool FilterOperationResolver::createFilterOperations(CSSValue* inValue, const CS

CSSSVGDocumentValue* svgDocumentValue = toCSSSVGDocumentValue(argument);

KURL url = state.document().completeURL(svgDocumentValue->url());

- RefPtr<ReferenceFilterOperation> operation = ReferenceFilterOperation::create(svgDocumentValue->url(), url.fragmentIdentifier());

+ RefPtr<ReferenceFilterOperation> operation = ReferenceFilterOperation::create(svgDocumentValue->url(), AtomicString(url.fragmentIdentifier()));

if (SVGURIReference::isExternalURIReference(svgDocumentValue->url(), state.document())) {

if (!svgDocumentValue->loadRequested())

state.elementStyleResources().addPendingSVGDocument(operation.get(), svgDocumentValue);

« no previous file with comments | « no previous file | Source/core/css/resolver/StyleBuilderConverter.h » ('j') | no next file with comments »