Source/core/svg/SVGScriptElement.cpp - Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGScriptElement.cpp

Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take feedback into consideration Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGScriptElement.cpp

diff --git a/Source/core/svg/SVGScriptElement.cpp b/Source/core/svg/SVGScriptElement.cpp

index 871b2353fd728c89b0e1e1c8875442202a0036bf..f5956167dc25fe0052ffa6cf5fad8e074494eba0 100644

--- a/Source/core/svg/SVGScriptElement.cpp

+++ b/Source/core/svg/SVGScriptElement.cpp

@@ -137,7 +137,7 @@ void SVGScriptElement::childrenChanged(bool changedByParser, Node* beforeChange,

bool SVGScriptElement::isURLAttribute(const Attribute& attribute) const

{

- return attribute.name() == sourceAttributeValue();

+ return attribute.name() == AtomicString(sourceAttributeValue());

}

void SVGScriptElement::finishParsingChildren()

« no previous file with comments | « Source/core/svg/SVGPolyElement.cpp ('k') | Source/core/svg/SVGTextPathElement.cpp » ('j') | no next file with comments »