Source/core/svg/SVGFontData.cpp - Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGFontData.cpp

Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take feedback into consideration Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGFontData.cpp

diff --git a/Source/core/svg/SVGFontData.cpp b/Source/core/svg/SVGFontData.cpp

index 64b6b3de5cac3cb94242011f1907002c3a8ed97c..3b3ea8f594fd046f0ad46fb2eb9c55ac2dc52d24 100644

--- a/Source/core/svg/SVGFontData.cpp

+++ b/Source/core/svg/SVGFontData.cpp

@@ -165,7 +165,7 @@ bool SVGFontData::applySVGGlyphSelection(WidthIterator& iterator, GlyphData& gly

String language;

bool isVerticalText = false;

- Vector<String> altGlyphNames;

+ Vector<AtomicString> altGlyphNames;

if (renderObject) {

RenderObject* parentRenderObject = renderObject->isText() ? renderObject->parent() : renderObject;

« no previous file with comments | « Source/core/svg/SVGFETileElement.cpp ('k') | Source/core/svg/SVGGlyphRefElement.h » ('j') | no next file with comments »