Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Unified Diff: Source/core/rendering/svg/SVGResources.cpp

Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take feedback into consideration Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/svg/RenderSVGResourceFilter.cpp ('k') | Source/core/svg/SVGAElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/svg/SVGResources.cpp
diff --git a/Source/core/rendering/svg/SVGResources.cpp b/Source/core/rendering/svg/SVGResources.cpp
index b9c6f5903d326caebafe9a0c28e0e0cd7079ed65..85f2283168c4e1cd57cb6b4dfec6b16bfd537f26 100644
--- a/Source/core/rendering/svg/SVGResources.cpp
+++ b/Source/core/rendering/svg/SVGResources.cpp
@@ -137,7 +137,7 @@ static HashSet<AtomicString>& chainableResourceTags()
return s_tagList;
}
-static inline String targetReferenceFromResource(SVGElement* element)
+static inline AtomicString targetReferenceFromResource(SVGElement* element)
{
String target;
if (element->hasTagName(SVGNames::patternTag))
@@ -233,19 +233,19 @@ PassOwnPtr<SVGResources> SVGResources::buildResources(const RenderObject* object
OwnPtr<SVGResources> resources;
if (clipperFilterMaskerTags().contains(tagName)) {
if (style->hasClipper()) {
- AtomicString id(style->clipperResource());
+ AtomicString id = style->clipperResource();
if (!ensureResources(resources)->setClipper(getRenderSVGResourceById<RenderSVGResourceClipper>(document, id)))
registerPendingResource(extensions, id, element);
}
if (style->hasFilter()) {
- AtomicString id(style->filterResource());
+ AtomicString id = style->filterResource();
if (!ensureResources(resources)->setFilter(getRenderSVGResourceById<RenderSVGResourceFilter>(document, id)))
registerPendingResource(extensions, id, element);
}
if (style->hasMasker()) {
- AtomicString id(style->maskerResource());
+ AtomicString id = style->maskerResource();
if (!ensureResources(resources)->setMasker(getRenderSVGResourceById<RenderSVGResourceMasker>(document, id)))
registerPendingResource(extensions, id, element);
}
@@ -286,7 +286,7 @@ PassOwnPtr<SVGResources> SVGResources::buildResources(const RenderObject* object
}
if (chainableResourceTags().contains(tagName)) {
- AtomicString id(targetReferenceFromResource(element));
+ AtomicString id = targetReferenceFromResource(element);
if (!ensureResources(resources)->setLinkedResource(getRenderSVGResourceContainerById(document, id)))
registerPendingResource(extensions, id, element);
}
« no previous file with comments | « Source/core/rendering/svg/RenderSVGResourceFilter.cpp ('k') | Source/core/svg/SVGAElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698