Source/core/svg/SVGURIReference.h - Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGURIReference.h

Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take feedback into consideration Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGURIReference.h

diff --git a/Source/core/svg/SVGURIReference.h b/Source/core/svg/SVGURIReference.h

index f73a23bd2bff1e0f06f12f8fe30772fb663fadc3..c940502e53291d1c65f53e3d7120c1b234106fdd 100644

--- a/Source/core/svg/SVGURIReference.h

+++ b/Source/core/svg/SVGURIReference.h

@@ -36,8 +36,8 @@ public:

bool isKnownAttribute(const QualifiedName&);

void addSupportedAttributes(HashSet<QualifiedName>&);

- static String fragmentIdentifierFromIRIString(const String&, const Document&);

- static Element* targetElementFromIRIString(const String&, const Document&, String* = 0, Document* = 0);

+ static AtomicString fragmentIdentifierFromIRIString(const String&, const Document&);

+ static Element* targetElementFromIRIString(const String&, const Document&, AtomicString* = 0, Document* = 0);

static inline bool isExternalURIReference(const String& uri, const Document& document)

{

« no previous file with comments | « Source/core/svg/SVGTextPathElement.cpp ('k') | Source/core/svg/SVGURIReference.cpp » ('j') | no next file with comments »