Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: Source/core/svg/SVGTextPathElement.cpp

Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take feedback into consideration Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/svg/SVGScriptElement.cpp ('k') | Source/core/svg/SVGURIReference.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2010 Rob Buis <rwlbuis@gmail.com> 3 * Copyright (C) 2010 Rob Buis <rwlbuis@gmail.com>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 148
149 return false; 149 return false;
150 } 150 }
151 151
152 void SVGTextPathElement::buildPendingResource() 152 void SVGTextPathElement::buildPendingResource()
153 { 153 {
154 clearResourceReferences(); 154 clearResourceReferences();
155 if (!inDocument()) 155 if (!inDocument())
156 return; 156 return;
157 157
158 String id; 158 AtomicString id;
159 Element* target = SVGURIReference::targetElementFromIRIString(hrefCurrentVal ue(), document(), &id); 159 Element* target = SVGURIReference::targetElementFromIRIString(hrefCurrentVal ue(), document(), &id);
160 if (!target) { 160 if (!target) {
161 // Do not register as pending if we are already pending this resource. 161 // Do not register as pending if we are already pending this resource.
162 if (document().accessSVGExtensions()->isElementPendingResource(this, id) ) 162 if (document().accessSVGExtensions()->isElementPendingResource(this, id) )
163 return; 163 return;
164 164
165 if (!id.isEmpty()) { 165 if (!id.isEmpty()) {
166 document().accessSVGExtensions()->addPendingResource(id, this); 166 document().accessSVGExtensions()->addPendingResource(id, this);
167 ASSERT(hasPendingResources()); 167 ASSERT(hasPendingResources());
168 } 168 }
(...skipping 18 matching lines...) Expand all
187 clearResourceReferences(); 187 clearResourceReferences();
188 } 188 }
189 189
190 bool SVGTextPathElement::selfHasRelativeLengths() const 190 bool SVGTextPathElement::selfHasRelativeLengths() const
191 { 191 {
192 return startOffsetCurrentValue().isRelative() 192 return startOffsetCurrentValue().isRelative()
193 || SVGTextContentElement::selfHasRelativeLengths(); 193 || SVGTextContentElement::selfHasRelativeLengths();
194 } 194 }
195 195
196 } 196 }
OLDNEW
« no previous file with comments | « Source/core/svg/SVGScriptElement.cpp ('k') | Source/core/svg/SVGURIReference.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698