Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Side by Side Diff: Source/core/rendering/svg/SVGResources.cpp

Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 2 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 break; 165 break;
166 } 166 }
167 return false; 167 return false;
168 } 168 }
169 169
170 static inline RenderSVGResourceContainer* paintingResourceFromSVGPaint(Document& document, const SVGPaint::SVGPaintType& paintType, const String& paintUri, Atom icString& id, bool& hasPendingResource) 170 static inline RenderSVGResourceContainer* paintingResourceFromSVGPaint(Document& document, const SVGPaint::SVGPaintType& paintType, const String& paintUri, Atom icString& id, bool& hasPendingResource)
171 { 171 {
172 if (!svgPaintTypeHasURL(paintType)) 172 if (!svgPaintTypeHasURL(paintType))
173 return 0; 173 return 0;
174 174
175 id = SVGURIReference::fragmentIdentifierFromIRIString(paintUri, document); 175 id = AtomicString(SVGURIReference::fragmentIdentifierFromIRIString(paintUri, document));
eseidel 2014/01/01 01:42:07 Again, fragments seem to always ben AtomicStrings.
Inactive 2014/01/01 16:12:59 Done.
176 RenderSVGResourceContainer* container = getRenderSVGResourceContainerById(do cument, id); 176 RenderSVGResourceContainer* container = getRenderSVGResourceContainerById(do cument, id);
177 if (!container) { 177 if (!container) {
178 hasPendingResource = true; 178 hasPendingResource = true;
179 return 0; 179 return 0;
180 } 180 }
181 181
182 RenderSVGResourceType resourceType = container->resourceType(); 182 RenderSVGResourceType resourceType = container->resourceType();
183 if (resourceType != PatternResourceType && resourceType != LinearGradientRes ourceType && resourceType != RadialGradientResourceType) 183 if (resourceType != PatternResourceType && resourceType != LinearGradientRes ourceType && resourceType != RadialGradientResourceType)
184 return 0; 184 return 0;
185 185
(...skipping 514 matching lines...) Expand 10 before | Expand all | Expand 10 after
700 if (RenderSVGResourceContainer* stroke = m_fillStrokeData->stroke) 700 if (RenderSVGResourceContainer* stroke = m_fillStrokeData->stroke)
701 fprintf(stderr, " |-> Stroke : %p (node=%p)\n", stroke, stroke-> element()); 701 fprintf(stderr, " |-> Stroke : %p (node=%p)\n", stroke, stroke-> element());
702 } 702 }
703 703
704 if (m_linkedResource) 704 if (m_linkedResource)
705 fprintf(stderr, " |-> xlink:href : %p (node=%p)\n", m_linkedResource, m_ linkedResource->element()); 705 fprintf(stderr, " |-> xlink:href : %p (node=%p)\n", m_linkedResource, m_ linkedResource->element());
706 } 706 }
707 #endif 707 #endif
708 708
709 } 709 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698