Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Side by Side Diff: Source/core/svg/SVGFEConvolveMatrixElement.cpp

Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take feedback into consideration Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org> 2 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 265 matching lines...) Expand 10 before | Expand all | Expand 10 after
276 || attrName == SVGNames::kernelMatrixAttr) { 276 || attrName == SVGNames::kernelMatrixAttr) {
277 invalidate(); 277 invalidate();
278 return; 278 return;
279 } 279 }
280 280
281 ASSERT_NOT_REACHED(); 281 ASSERT_NOT_REACHED();
282 } 282 }
283 283
284 PassRefPtr<FilterEffect> SVGFEConvolveMatrixElement::build(SVGFilterBuilder* fil terBuilder, Filter* filter) 284 PassRefPtr<FilterEffect> SVGFEConvolveMatrixElement::build(SVGFilterBuilder* fil terBuilder, Filter* filter)
285 { 285 {
286 FilterEffect* input1 = filterBuilder->getEffectById(in1CurrentValue()); 286 FilterEffect* input1 = filterBuilder->getEffectById(AtomicString(in1CurrentV alue()));
287 287
288 if (!input1) 288 if (!input1)
289 return 0; 289 return 0;
290 290
291 int orderXValue = orderXCurrentValue(); 291 int orderXValue = orderXCurrentValue();
292 int orderYValue = orderYCurrentValue(); 292 int orderYValue = orderYCurrentValue();
293 if (!hasAttribute(SVGNames::orderAttr)) { 293 if (!hasAttribute(SVGNames::orderAttr)) {
294 orderXValue = 3; 294 orderXValue = 3;
295 orderYValue = 3; 295 orderYValue = 3;
296 } 296 }
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
338 338
339 RefPtr<FilterEffect> effect = FEConvolveMatrix::create(filter, 339 RefPtr<FilterEffect> effect = FEConvolveMatrix::create(filter,
340 IntSize(orderXValue, orderYValue), divisorValue, 340 IntSize(orderXValue, orderYValue), divisorValue,
341 biasCurrentValue(), IntPoint(targetXValue, targetYValue), ed geModeCurrentValue(), 341 biasCurrentValue(), IntPoint(targetXValue, targetYValue), ed geModeCurrentValue(),
342 FloatPoint(kernelUnitLengthXValue, kernelUnitLengthYValue), preserveAlphaCurrentValue(), kernelMatrix.toFloatVector()); 342 FloatPoint(kernelUnitLengthXValue, kernelUnitLengthYValue), preserveAlphaCurrentValue(), kernelMatrix.toFloatVector());
343 effect->inputEffects().append(input1); 343 effect->inputEffects().append(input1);
344 return effect.release(); 344 return effect.release();
345 } 345 }
346 346
347 } // namespace WebCore 347 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/svg/SVGFECompositeElement.cpp ('k') | Source/core/svg/SVGFEDiffuseLightingElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698