Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Side by Side Diff: Source/core/svg/SVGFEBlendElement.cpp

Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take feedback into consideration Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/svg/SVGElement.cpp ('k') | Source/core/svg/SVGFEColorMatrixElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 if (attrName == SVGNames::inAttr || attrName == SVGNames::in2Attr) { 119 if (attrName == SVGNames::inAttr || attrName == SVGNames::in2Attr) {
120 invalidate(); 120 invalidate();
121 return; 121 return;
122 } 122 }
123 123
124 ASSERT_NOT_REACHED(); 124 ASSERT_NOT_REACHED();
125 } 125 }
126 126
127 PassRefPtr<FilterEffect> SVGFEBlendElement::build(SVGFilterBuilder* filterBuilde r, Filter* filter) 127 PassRefPtr<FilterEffect> SVGFEBlendElement::build(SVGFilterBuilder* filterBuilde r, Filter* filter)
128 { 128 {
129 FilterEffect* input1 = filterBuilder->getEffectById(in1CurrentValue()); 129 FilterEffect* input1 = filterBuilder->getEffectById(AtomicString(in1CurrentV alue()));
130 FilterEffect* input2 = filterBuilder->getEffectById(in2CurrentValue()); 130 FilterEffect* input2 = filterBuilder->getEffectById(AtomicString(in2CurrentV alue()));
131 131
132 if (!input1 || !input2) 132 if (!input1 || !input2)
133 return 0; 133 return 0;
134 134
135 RefPtr<FilterEffect> effect = FEBlend::create(filter, modeCurrentValue()); 135 RefPtr<FilterEffect> effect = FEBlend::create(filter, modeCurrentValue());
136 FilterEffectVector& inputEffects = effect->inputEffects(); 136 FilterEffectVector& inputEffects = effect->inputEffects();
137 inputEffects.reserveCapacity(2); 137 inputEffects.reserveCapacity(2);
138 inputEffects.append(input1); 138 inputEffects.append(input1);
139 inputEffects.append(input2); 139 inputEffects.append(input2);
140 return effect.release(); 140 return effect.release();
141 } 141 }
142 142
143 } 143 }
OLDNEW
« no previous file with comments | « Source/core/svg/SVGElement.cpp ('k') | Source/core/svg/SVGFEColorMatrixElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698