Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1504)

Unified Diff: Source/core/svg/SVGElement.cpp

Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take feedback into consideration Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGElement.h ('k') | Source/core/svg/SVGFEBlendElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGElement.cpp
diff --git a/Source/core/svg/SVGElement.cpp b/Source/core/svg/SVGElement.cpp
index 43758475f955e5245511777ad5a9b10650055b7c..9d3bfe2e71a23a52bbeb5a7f13b2f3f6eb307326 100644
--- a/Source/core/svg/SVGElement.cpp
+++ b/Source/core/svg/SVGElement.cpp
@@ -147,7 +147,7 @@ void SVGElement::buildPendingResourcesIfNeeded()
return;
SVGDocumentExtensions* extensions = document.accessSVGExtensions();
- String resourceId = getIdAttribute();
+ AtomicString resourceId = getIdAttribute();
if (!extensions->hasPendingResource(resourceId))
return;
@@ -279,7 +279,7 @@ String SVGElement::title() const
return String();
}
-PassRefPtr<CSSValue> SVGElement::getPresentationAttribute(const String& name)
+PassRefPtr<CSSValue> SVGElement::getPresentationAttribute(const AtomicString& name)
{
if (!hasAttributesWithoutUpdate())
return 0;
@@ -314,32 +314,32 @@ AffineTransform SVGElement::localCoordinateSpaceTransform(CTMScope) const
return AffineTransform();
}
-String SVGElement::xmlbase() const
+const AtomicString& SVGElement::xmlbase() const
{
return fastGetAttribute(XMLNames::baseAttr);
}
-void SVGElement::setXMLbase(const String& value)
+void SVGElement::setXMLbase(const AtomicString& value)
{
setAttribute(XMLNames::baseAttr, value);
}
-String SVGElement::xmllang() const
+const AtomicString& SVGElement::xmllang() const
{
return fastGetAttribute(XMLNames::langAttr);
}
-void SVGElement::setXMLlang(const String& value)
+void SVGElement::setXMLlang(const AtomicString& value)
{
setAttribute(XMLNames::langAttr, value);
}
-String SVGElement::xmlspace() const
+const AtomicString& SVGElement::xmlspace() const
{
return fastGetAttribute(XMLNames::spaceAttr);
}
-void SVGElement::setXMLspace(const String& value)
+void SVGElement::setXMLspace(const AtomicString& value)
{
setAttribute(XMLNames::spaceAttr, value);
}
@@ -1027,7 +1027,7 @@ void SVGElement::svgAttributeChanged(const QualifiedName& attrName)
}
if (attrName == HTMLNames::classAttr) {
- classAttributeChanged(classNameCurrentValue());
+ classAttributeChanged(AtomicString(classNameCurrentValue()));
SVGElementInstance::invalidateAllInstancesOfElement(this);
return;
}
« no previous file with comments | « Source/core/svg/SVGElement.h ('k') | Source/core/svg/SVGFEBlendElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698