Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: Source/core/svg/SVGMPathElement.cpp

Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take feedback into consideration Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/svg/SVGImageElement.cpp ('k') | Source/core/svg/SVGPathElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 2 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 { 54 {
55 clearResourceReferences(); 55 clearResourceReferences();
56 } 56 }
57 57
58 void SVGMPathElement::buildPendingResource() 58 void SVGMPathElement::buildPendingResource()
59 { 59 {
60 clearResourceReferences(); 60 clearResourceReferences();
61 if (!inDocument()) 61 if (!inDocument())
62 return; 62 return;
63 63
64 String id; 64 AtomicString id;
65 Element* target = SVGURIReference::targetElementFromIRIString(hrefCurrentVal ue(), document(), &id); 65 Element* target = SVGURIReference::targetElementFromIRIString(hrefCurrentVal ue(), document(), &id);
66 if (!target) { 66 if (!target) {
67 // Do not register as pending if we are already pending this resource. 67 // Do not register as pending if we are already pending this resource.
68 if (document().accessSVGExtensions()->isElementPendingResource(this, id) ) 68 if (document().accessSVGExtensions()->isElementPendingResource(this, id) )
69 return; 69 return;
70 70
71 if (!id.isEmpty()) { 71 if (!id.isEmpty()) {
72 document().accessSVGExtensions()->addPendingResource(id, this); 72 document().accessSVGExtensions()->addPendingResource(id, this);
73 ASSERT(hasPendingResources()); 73 ASSERT(hasPendingResources());
74 } 74 }
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 notifyParentOfPathChange(parentNode()); 160 notifyParentOfPathChange(parentNode());
161 } 161 }
162 162
163 void SVGMPathElement::notifyParentOfPathChange(ContainerNode* parent) 163 void SVGMPathElement::notifyParentOfPathChange(ContainerNode* parent)
164 { 164 {
165 if (parent && parent->hasTagName(SVGNames::animateMotionTag)) 165 if (parent && parent->hasTagName(SVGNames::animateMotionTag))
166 static_cast<SVGAnimateMotionElement*>(parent)->updateAnimationPath(); 166 static_cast<SVGAnimateMotionElement*>(parent)->updateAnimationPath();
167 } 167 }
168 168
169 } // namespace WebCore 169 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/svg/SVGImageElement.cpp ('k') | Source/core/svg/SVGPathElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698