Source/core/svg/SVGGlyphRefElement.cpp - Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGGlyphRefElement.cpp

Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take feedback into consideration Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGGlyphRefElement.cpp

diff --git a/Source/core/svg/SVGGlyphRefElement.cpp b/Source/core/svg/SVGGlyphRefElement.cpp

index 5fd1b1c3667f248de8210a841cd3d383767581f4..9ab69993bfe3677ec7c0e9ca9a0bdad0f5f71906 100644

--- a/Source/core/svg/SVGGlyphRefElement.cpp

+++ b/Source/core/svg/SVGGlyphRefElement.cpp

@@ -52,7 +52,7 @@ PassRefPtr<SVGGlyphRefElement> SVGGlyphRefElement::create(Document& document)

return adoptRef(new SVGGlyphRefElement(document));

}

-bool SVGGlyphRefElement::hasValidGlyphElement(String& glyphName) const

+bool SVGGlyphRefElement::hasValidGlyphElement(AtomicString& glyphName) const

{

// FIXME: We only support xlink:href so far.

// https://bugs.webkit.org/show_bug.cgi?id=64787

« no previous file with comments | « Source/core/svg/SVGGlyphRefElement.h ('k') | Source/core/svg/SVGImageElement.cpp » ('j') | no next file with comments »