Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Side by Side Diff: Source/core/svg/SVGAltGlyphElement.cpp

Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take feedback into consideration Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/svg/SVGAltGlyphElement.h ('k') | Source/core/svg/SVGAltGlyphItemElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
4 * Copyright (C) 2008 Apple Inc. All rights reserved. 4 * Copyright (C) 2008 Apple Inc. All rights reserved.
5 * Copyright (C) 2011 Torch Mobile (Beijing) Co. Ltd. All rights reserved. 5 * Copyright (C) 2011 Torch Mobile (Beijing) Co. Ltd. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 if (child.isTextNode()) 79 if (child.isTextNode())
80 return true; 80 return true;
81 return false; 81 return false;
82 } 82 }
83 83
84 RenderObject* SVGAltGlyphElement::createRenderer(RenderStyle*) 84 RenderObject* SVGAltGlyphElement::createRenderer(RenderStyle*)
85 { 85 {
86 return new RenderSVGTSpan(this); 86 return new RenderSVGTSpan(this);
87 } 87 }
88 88
89 bool SVGAltGlyphElement::hasValidGlyphElements(Vector<String>& glyphNames) const 89 bool SVGAltGlyphElement::hasValidGlyphElements(Vector<AtomicString>& glyphNames) const
90 { 90 {
91 String target; 91 AtomicString target;
92 Element* element = targetElementFromIRIString(getAttribute(XLinkNames::hrefA ttr), document(), &target); 92 Element* element = targetElementFromIRIString(getAttribute(XLinkNames::hrefA ttr), document(), &target);
93 if (!element) 93 if (!element)
94 return false; 94 return false;
95 95
96 if (element->hasTagName(SVGNames::glyphTag)) { 96 if (element->hasTagName(SVGNames::glyphTag)) {
97 glyphNames.append(target); 97 glyphNames.append(target);
98 return true; 98 return true;
99 } 99 }
100 100
101 if (element->hasTagName(SVGNames::altGlyphDefTag) 101 if (element->hasTagName(SVGNames::altGlyphDefTag)
102 && static_cast<SVGAltGlyphDefElement*>(element)->hasValidGlyphElements(g lyphNames)) 102 && static_cast<SVGAltGlyphDefElement*>(element)->hasValidGlyphElements(g lyphNames))
103 return true; 103 return true;
104 104
105 return false; 105 return false;
106 } 106 }
107 107
108 } 108 }
109 109
110 #endif 110 #endif
OLDNEW
« no previous file with comments | « Source/core/svg/SVGAltGlyphElement.h ('k') | Source/core/svg/SVGAltGlyphItemElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698