Source/core/svg/SVGAElement.cpp - Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGAElement.cpp

Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take feedback into consideration Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGAElement.cpp

diff --git a/Source/core/svg/SVGAElement.cpp b/Source/core/svg/SVGAElement.cpp

index 5982da1283e346d42a64c971e0edcc0563a11a5c..4f3536c6e349c6326780fdf4f39491df831ddb18 100644

--- a/Source/core/svg/SVGAElement.cpp

+++ b/Source/core/svg/SVGAElement.cpp

@@ -161,7 +161,7 @@ void SVGAElement::defaultEventHandler(Event* event)

String url = stripLeadingAndTrailingHTMLSpaces(hrefCurrentValue());

if (url[0] == '#') {

- Element* targetElement = treeScope().getElementById(url.substring(1));

+ Element* targetElement = treeScope().getElementById(AtomicString(url.substring(1)));

if (targetElement && isSVGSMILElement(*targetElement)) {

toSVGSMILElement(targetElement)->beginByLinkActivation();

event->setDefaultHandled();

« no previous file with comments | « Source/core/rendering/svg/SVGResources.cpp ('k') | Source/core/svg/SVGAltGlyphDefElement.h » ('j') | no next file with comments »