Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1429)

Unified Diff: Source/core/svg/SVGElement.h

Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take feedback into consideration Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGAltGlyphItemElement.cpp ('k') | Source/core/svg/SVGElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGElement.h
diff --git a/Source/core/svg/SVGElement.h b/Source/core/svg/SVGElement.h
index fb3d8eb32c9368be79580048de03d10e1d8ea333..4aa33260e8d5fba43573d76b0d6d129a27be41db 100644
--- a/Source/core/svg/SVGElement.h
+++ b/Source/core/svg/SVGElement.h
@@ -56,7 +56,7 @@ public:
virtual String title() const;
bool hasRelativeLengths() const { return !m_elementsWithRelativeLengths.isEmpty(); }
virtual bool supportsMarkers() const { return false; }
- PassRefPtr<CSSValue> getPresentationAttribute(const String& name);
+ PassRefPtr<CSSValue> getPresentationAttribute(const AtomicString& name);
static bool isAnimatableCSSProperty(const QualifiedName&);
enum CTMScope {
NearestViewportScope, // Used by SVGGraphicsElement::getCTM()
@@ -68,14 +68,14 @@ public:
bool instanceUpdatesBlocked() const;
void setInstanceUpdatesBlocked(bool);
- String xmlbase() const;
- void setXMLbase(const String&);
+ const AtomicString& xmlbase() const;
+ void setXMLbase(const AtomicString&);
- String xmllang() const;
- void setXMLlang(const String& xmlLang);
+ const AtomicString& xmllang() const;
+ void setXMLlang(const AtomicString&);
- String xmlspace() const;
- void setXMLspace(const String& xmlSpace);
+ const AtomicString& xmlspace() const;
+ void setXMLspace(const AtomicString&);
SVGSVGElement* ownerSVGElement() const;
SVGElement* viewportElement() const;
« no previous file with comments | « Source/core/svg/SVGAltGlyphItemElement.cpp ('k') | Source/core/svg/SVGElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698