Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: Source/core/svg/SVGGlyphRefElement.cpp

Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take feedback into consideration Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/svg/SVGGlyphRefElement.h ('k') | Source/core/svg/SVGImageElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Leo Yang <leoyang@webkit.org> 2 * Copyright (C) 2011 Leo Yang <leoyang@webkit.org>
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 { 45 {
46 ScriptWrappable::init(this); 46 ScriptWrappable::init(this);
47 registerAnimatedPropertiesForSVGGlyphRefElement(); 47 registerAnimatedPropertiesForSVGGlyphRefElement();
48 } 48 }
49 49
50 PassRefPtr<SVGGlyphRefElement> SVGGlyphRefElement::create(Document& document) 50 PassRefPtr<SVGGlyphRefElement> SVGGlyphRefElement::create(Document& document)
51 { 51 {
52 return adoptRef(new SVGGlyphRefElement(document)); 52 return adoptRef(new SVGGlyphRefElement(document));
53 } 53 }
54 54
55 bool SVGGlyphRefElement::hasValidGlyphElement(String& glyphName) const 55 bool SVGGlyphRefElement::hasValidGlyphElement(AtomicString& glyphName) const
56 { 56 {
57 // FIXME: We only support xlink:href so far. 57 // FIXME: We only support xlink:href so far.
58 // https://bugs.webkit.org/show_bug.cgi?id=64787 58 // https://bugs.webkit.org/show_bug.cgi?id=64787
59 Element* element = targetElementFromIRIString(getAttribute(XLinkNames::hrefA ttr), document(), &glyphName); 59 Element* element = targetElementFromIRIString(getAttribute(XLinkNames::hrefA ttr), document(), &glyphName);
60 if (!element || !element->hasTagName(SVGNames::glyphTag)) 60 if (!element || !element->hasTagName(SVGNames::glyphTag))
61 return false; 61 return false;
62 return true; 62 return true;
63 } 63 }
64 64
65 template<typename CharType> 65 template<typename CharType>
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 void SVGGlyphRefElement::setDy(float dy) 127 void SVGGlyphRefElement::setDy(float dy)
128 { 128 {
129 // FIXME: Honor attribute change. 129 // FIXME: Honor attribute change.
130 // https://bugs.webkit.org/show_bug.cgi?id=64787 130 // https://bugs.webkit.org/show_bug.cgi?id=64787
131 m_dy = dy; 131 m_dy = dy;
132 } 132 }
133 133
134 } 134 }
135 135
136 #endif 136 #endif
OLDNEW
« no previous file with comments | « Source/core/svg/SVGGlyphRefElement.h ('k') | Source/core/svg/SVGImageElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698