Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1202293002: Move GLSL-specific routines/classes to separate glsl directory (Closed)

Created:
5 years, 6 months ago by jvanverth1
Modified:
5 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move GLSL-specific routines/classes to separate glsl directory The purpose is to begin separating our GLSL-specific code from our GL-specific code, so it can be used with the GL45 platform Committed: https://skia.googlesource.com/skia/+/cba99b88fd5fb39def7a094dc32c0745c7a1cfea

Patch Set 1 #

Patch Set 2 : Rename GrGLGLSL.{cpp,h} #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -885 lines) Patch
M gyp/gpu.gypi View 1 3 chunks +9 lines, -3 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrAALinearizingConvexPathRenderer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrPathProcessor.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/effects/GrConstColorProcessor.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/effects/GrCustomXfermode.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/effects/GrDitherEffect.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/effects/GrOvalEffect.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLCaps.h View 3 chunks +5 lines, -85 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 8 chunks +22 lines, -59 lines 0 comments Download
M src/gpu/gl/GrGLContext.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLContext.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
A src/gpu/gl/GrGLGLSL.h View 1 1 chunk +36 lines, -0 lines 0 comments Download
A + src/gpu/gl/GrGLGLSL.cpp View 1 4 chunks +4 lines, -30 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 4 chunks +5 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLProgram.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLProgramDataManager.h View 1 chunk +0 lines, -1 line 0 comments Download
D src/gpu/gl/GrGLSL.h View 1 chunk +0 lines, -347 lines 0 comments Download
D src/gpu/gl/GrGLSL.cpp View 1 chunk +0 lines, -135 lines 0 comments Download
D src/gpu/gl/GrGLSL_impl.h View 1 chunk +0 lines, -175 lines 0 comments Download
M src/gpu/gl/GrGLShaderVar.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 1 2 chunks +7 lines, -5 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLShaderBuilder.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
A + src/gpu/glsl/GrGLSL.h View 2 chunks +0 lines, -21 lines 0 comments Download
A src/gpu/glsl/GrGLSL.cpp View 1 chunk +35 lines, -0 lines 0 comments Download
A src/gpu/glsl/GrGLSLCaps.h View 1 chunk +94 lines, -0 lines 0 comments Download
A src/gpu/glsl/GrGLSLCaps.cpp View 1 chunk +47 lines, -0 lines 0 comments Download
A + src/gpu/glsl/GrGLSL_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jvanverth1
It's not as bad as it looks -- most of it is renaming or removing ...
5 years, 6 months ago (2015-06-23 20:46:55 UTC) #3
jvanverth1
Renamed GrGLQueryGLSLProps to GrGLGLSL. PTAL.
5 years, 6 months ago (2015-06-24 13:45:41 UTC) #4
bsalomon
On 2015/06/24 13:45:41, jvanverth1 wrote: > Renamed GrGLQueryGLSLProps to GrGLGLSL. PTAL. lgtm
5 years, 6 months ago (2015-06-24 13:50:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202293002/20001
5 years, 6 months ago (2015-06-24 13:53:56 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 14:00:06 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/cba99b88fd5fb39def7a094dc32c0745c7a1cfea

Powered by Google App Engine
This is Rietveld 408576698