Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 893533003: Revert "Make GCC happy again." and "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.". (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer
Modified:
5 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "Make GCC happy again." and "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.". This reverts commit 6a4c0a3bae60b1a2239f35e3b759bd215e3886fe and commit 0deaa4b629faeae6832046c294dc7c034a0a6653 for breaking GCC bots. TBR=svenpanne@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/883852293a3191006597853dbb6643f7e6f0da0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2187 lines, -2006 lines) Patch
M include/v8-profiler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/full-codegen-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/full-codegen-arm64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/base/logging.h View 4 chunks +145 lines, -105 lines 0 comments Download
M src/base/logging.cc View 2 chunks +3 lines, -35 lines 0 comments Download
M src/base/platform/condition-variable.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/base/platform/time.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/base/platform/time.cc View 2 chunks +1 line, -7 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/checks.h View 3 chunks +26 lines, -6 lines 0 comments Download
M src/checks.cc View 1 chunk +81 lines, -2 lines 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 8 chunks +13 lines, -16 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/code-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/control-reducer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/instruction.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/js-inlining.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/loop-peeling.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/machine-operator-reducer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/move-optimizer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/node.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/osr.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/pipeline.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/register-allocator-verifier.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/scheduler.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M src/compiler/verifier.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/zone-pool.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/deoptimizer.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/deoptimizer.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/spaces.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/hydrogen.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/hydrogen-check-elimination.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/handler-compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic-state.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ic/x64/stub-cache-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/jsregexp.h View 1 chunk +1 line, -1 line 0 comments Download
M src/jsregexp.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M src/log.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.h View 2 chunks +12 lines, -12 lines 0 comments Download
M src/objects.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/optimizing-compiler-thread.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/perf-jit.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/full-codegen-ppc.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/serialize.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/serialize.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M src/unique.h View 1 chunk +1 line, -1 line 0 comments Download
M src/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/disasm-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/full-codegen-x87.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/cctest.h View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/codegen-tester.h View 1 chunk +0 lines, -10 lines 0 comments Download
M test/cctest/compiler/codegen-tester.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/compiler/function-tester.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/graph-builder-tester.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-basic-block-profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-control-reducer.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M test/cctest/compiler/test-instruction.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-js-constant-cache.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-linkage.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-loop-analysis.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-loop-assignment-analysis.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-machine-operator-reducer.cc View 7 chunks +132 lines, -10 lines 0 comments Download
M test/cctest/compiler/test-node.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-node-cache.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-operator.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M test/cctest/compiler/test-representation-change.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 92 chunks +112 lines, -108 lines 0 comments Download
M test/cctest/compiler/value-helper.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-accessors.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M test/cctest/test-api.cc View 159 chunks +346 lines, -352 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 5 chunks +29 lines, -29 lines 0 comments Download
M test/cctest/test-assembler-arm64.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-assembler-ia32.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-assembler-x64.cc View 11 chunks +26 lines, -26 lines 0 comments Download
M test/cctest/test-bignum.cc View 19 chunks +290 lines, -330 lines 0 comments Download
M test/cctest/test-bignum-dtoa.cc View 5 chunks +36 lines, -36 lines 0 comments Download
A test/cctest/test-checks.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M test/cctest/test-circular-queue.cc View 4 chunks +21 lines, -21 lines 0 comments Download
M test/cctest/test-conversions.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 16 chunks +32 lines, -32 lines 0 comments Download
M test/cctest/test-debug.cc View 11 chunks +13 lines, -12 lines 0 comments Download
M test/cctest/test-decls.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-deoptimization.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-dtoa.cc View 8 chunks +37 lines, -37 lines 0 comments Download
M test/cctest/test-fast-dtoa.cc View 10 chunks +24 lines, -24 lines 0 comments Download
M test/cctest/test-feedback-vector.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-fixed-dtoa.cc View 2 chunks +110 lines, -110 lines 0 comments Download
M test/cctest/test-flags.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-func-name-inference.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-global-object.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-hashmap.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 78 chunks +267 lines, -257 lines 0 comments Download
M test/cctest/test-lockers.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M test/cctest/test-log.cc View 5 chunks +10 lines, -7 lines 0 comments Download
M test/cctest/test-log-stack-tracer.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M test/cctest/test-macro-assembler-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M test/cctest/test-platform.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/test-profile-generator.cc View 15 chunks +114 lines, -114 lines 0 comments Download
M test/cctest/test-regexp.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/test-sampler-api.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-strings.cc View 5 chunks +7 lines, -8 lines 0 comments Download
M test/cctest/test-symbols.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-version.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M test/cctest/trace-extension.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D test/unittests/base/logging-unittest.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M test/unittests/compiler/instruction-sequence-unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/scheduler-unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
5 years, 10 months ago (2015-01-30 07:19:18 UTC) #1
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/883852293a3191006597853dbb6643f7e6f0da0d Cr-Commit-Position: refs/heads/master@{#26342}
5 years, 10 months ago (2015-01-30 07:20:04 UTC) #2
Benedikt Meurer
5 years, 10 months ago (2015-01-30 07:20:05 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
883852293a3191006597853dbb6643f7e6f0da0d (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698