Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: test/cctest/test-parsing.cc

Issue 893533003: Revert "Make GCC happy again." and "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.". (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-macro-assembler-arm.cc ('k') | test/cctest/test-platform.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-parsing.cc
diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc
index 56d64ff954cf851027b2b9afaf6a04e377ff8104..f15224f8da0d7d444f75cf04fc25f56f4d11e3ef 100644
--- a/test/cctest/test-parsing.cc
+++ b/test/cctest/test-parsing.cc
@@ -375,7 +375,7 @@ TEST(PreparsingObjectLiterals) {
v8::Local<v8::Value> result = ParserCacheCompileRun(source);
CHECK(result->IsString());
v8::String::Utf8Value utf8(result);
- CHECK_EQ(0, strcmp("foo", *utf8));
+ CHECK_EQ("foo", *utf8);
}
{
@@ -383,7 +383,7 @@ TEST(PreparsingObjectLiterals) {
v8::Local<v8::Value> result = ParserCacheCompileRun(source);
CHECK(result->IsString());
v8::String::Utf8Value utf8(result);
- CHECK_EQ(0, strcmp("foo", *utf8));
+ CHECK_EQ("foo", *utf8);
}
{
@@ -391,7 +391,7 @@ TEST(PreparsingObjectLiterals) {
v8::Local<v8::Value> result = ParserCacheCompileRun(source);
CHECK(result->IsString());
v8::String::Utf8Value utf8(result);
- CHECK_EQ(0, strcmp("foo", *utf8));
+ CHECK_EQ("foo", *utf8);
}
}
@@ -1670,9 +1670,8 @@ TEST(StrictOctal) {
v8::Script::Compile(v8::String::NewFromUtf8(CcTest::isolate(), script));
CHECK(try_catch.HasCaught());
v8::String::Utf8Value exception(try_catch.Exception());
- CHECK_EQ(0,
- strcmp("SyntaxError: Octal literals are not allowed in strict mode.",
- *exception));
+ CHECK_EQ("SyntaxError: Octal literals are not allowed in strict mode.",
+ *exception);
}
« no previous file with comments | « test/cctest/test-macro-assembler-arm.cc ('k') | test/cctest/test-platform.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698