test/cctest/test-platform.cc - Issue 893533003: Revert "Make GCC happy again." and "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-platform.cc

Issue 893533003: Revert "Make GCC happy again." and "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.". (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-platform.cc

diff --git a/test/cctest/test-platform.cc b/test/cctest/test-platform.cc

index 2576af81a556a0dbd6dab1167709146555240f08..a786d368e1fa731805ab8482f7afbc4277d56593 100644

--- a/test/cctest/test-platform.cc

+++ b/test/cctest/test-platform.cc

@@ -56,8 +56,7 @@ TEST(StackAlignment) {

v8::Local<v8::Function>::Cast(global_object->Get(v8_str("foo")));

v8::Local<v8::Value> result = foo->Call(global_object, 0, NULL);

- CHECK_EQ(0u,

- result->Uint32Value() % v8::base::OS::ActivationFrameAlignment());

+ CHECK_EQ(0, result->Uint32Value() % v8::base::OS::ActivationFrameAlignment());

}

#endif // V8_CC_GNU

« no previous file with comments | « test/cctest/test-parsing.cc ('k') | test/cctest/test-profile-generator.cc » ('j') | no next file with comments »