Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: src/isolate.cc

Issue 893533003: Revert "Make GCC happy again." and "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.". (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/x64/stub-cache-x64.cc ('k') | src/jsregexp.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdlib.h> 5 #include <stdlib.h>
6 6
7 #include <fstream> // NOLINT(readability/streams) 7 #include <fstream> // NOLINT(readability/streams)
8 #include <sstream> 8 #include <sstream>
9 9
10 #include "src/v8.h" 10 #include "src/v8.h"
(...skipping 1542 matching lines...) Expand 10 before | Expand all | Expand 10 after
1553 1553
1554 Isolate::ThreadDataTable::ThreadDataTable() 1554 Isolate::ThreadDataTable::ThreadDataTable()
1555 : list_(NULL) { 1555 : list_(NULL) {
1556 } 1556 }
1557 1557
1558 1558
1559 Isolate::ThreadDataTable::~ThreadDataTable() { 1559 Isolate::ThreadDataTable::~ThreadDataTable() {
1560 // TODO(svenpanne) The assertion below would fire if an embedder does not 1560 // TODO(svenpanne) The assertion below would fire if an embedder does not
1561 // cleanly dispose all Isolates before disposing v8, so we are conservative 1561 // cleanly dispose all Isolates before disposing v8, so we are conservative
1562 // and leave it out for now. 1562 // and leave it out for now.
1563 // DCHECK_NULL(list_); 1563 // DCHECK_EQ(NULL, list_);
1564 } 1564 }
1565 1565
1566 1566
1567 Isolate::PerIsolateThreadData::~PerIsolateThreadData() { 1567 Isolate::PerIsolateThreadData::~PerIsolateThreadData() {
1568 #if defined(USE_SIMULATOR) 1568 #if defined(USE_SIMULATOR)
1569 delete simulator_; 1569 delete simulator_;
1570 #endif 1570 #endif
1571 } 1571 }
1572 1572
1573 1573
(...skipping 981 matching lines...) Expand 10 before | Expand all | Expand 10 after
2555 if (prev_ && prev_->Intercept(flag)) return true; 2555 if (prev_ && prev_->Intercept(flag)) return true;
2556 // Then check whether this scope intercepts. 2556 // Then check whether this scope intercepts.
2557 if ((flag & intercept_mask_)) { 2557 if ((flag & intercept_mask_)) {
2558 intercepted_flags_ |= flag; 2558 intercepted_flags_ |= flag;
2559 return true; 2559 return true;
2560 } 2560 }
2561 return false; 2561 return false;
2562 } 2562 }
2563 2563
2564 } } // namespace v8::internal 2564 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ic/x64/stub-cache-x64.cc ('k') | src/jsregexp.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698